cmnt: [X] [PATCH] fixes for LP: #1415636/CVE-2015-1350

Andy Whitcroft apw at canonical.com
Thu Aug 2 09:29:59 UTC 2018


On Thu, Aug 02, 2018 at 12:00:13PM +0300, José Pekkarinen wrote:
> On Thursday, 2 August 2018 08:44:30 EEST Khaled Elmously wrote:
> [snip]
> > > +	struct dentry 		*dentry = inode->i_sb->s_root;
> > 
> > I'm not sure I understand the above line. Can you please explain why it's
> > true?
> 
> 	Seems to be the only way to find the dentry struct associated to an inode, 
> in newer kernels most of the functions modified in this patch already receives 
> a dentry instead of a raw inode, but for the remaining cases something needs 
> to be tailored. I failed to find any macro to help with this endeavour.

That isn't 'the' dentry associated with an inode, that is the dentry
associated with root of the filesystem.  Surely you would have to
iterate over the inode->i_dentry list looking for a valid one.

-apw




More information about the kernel-team mailing list