NACK/cmnt: [Xenial][PATCH 0/3] a fix for mwifiex

Kleber Souza kleber.souza at canonical.com
Mon Apr 30 14:12:25 UTC 2018


On 04/23/18 12:27, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1712746
> 
> There were two workaround appied for lp:1712746 and now that the
> fix from Marvell has been accepted by upstream, it's time to integrate
> the fix instead.
> 
> There are three patches in this series: two for reverting the workaround
> patches, and one to apply the fix.
> 
> The fix has been verified on real hardware.
> 
> 
> Limin Zhu (1):
>   mwifiex: cfg80211: do not change virtual interface during scan
>     processing
> 
> Wen-chien Jesse Sung (2):
>   Revert "UBUNTU: SAUCE: mwifiex: do not dereference invalid pointer"
>   Revert "UBUNTU: SAUCE: net/wireless: do not dereference invalid
>     pointer"
> 
>  drivers/net/wireless/mwifiex/cfg80211.c | 6 ++++++
>  drivers/net/wireless/mwifiex/cfp.c      | 4 +---
>  net/wireless/util.c                     | 2 +-
>  3 files changed, 8 insertions(+), 4 deletions(-)
> 

Hi Jesse,

The reverts and the fix make sense to me and I would ACK them, however
the LP bug used on the patches has already been 'Fix Released'. In such
cases we recommend opening a new bug report so we can track the progress
of the follow-up fix accordingly.

Could you please open a new LP bug and submit the patches with an
updated BugLink reference?


Thank you,
Kleber




More information about the kernel-team mailing list