ACK: [SRU][Artful][Bionic][PATCH 1/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode
Colin Ian King
colin.king at canonical.com
Fri Apr 27 18:36:16 UTC 2018
On 27/04/18 19:25, Joseph Salisbury wrote:
> On 04/27/2018 02:05 PM, Colin Ian King wrote:
>> On 27/04/18 19:02, Joseph Salisbury wrote:
>>> From: Antonio Rosario Intilisano <antonio.intilisano at gmail.com>
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/1766054
>>>
>>> Now that we have informed the firmware that the Power Button driver is
>>> active, laptops such as the Acer Swift 3 will generate a WMI key event with
>>> code 0x87 when the power button key is pressed. Add this keycode to the
>>> table so that it is converted to an appropriate input event.
>>>
>>> Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano at gmail.com>
>>> Acked-by: Gianfranco Costamagna <locutusofborg at debian.org>
>>> Cc: Chris Chiu <chiu at endlessm.com>
>>> Cc: Daniel Drake <drake at endlessm.com>
>>> Cc: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>>> Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
>>> ---
>>> drivers/platform/x86/acer-wmi.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>>> index 1be71f9..8952173 100644
>>> --- a/drivers/platform/x86/acer-wmi.c
>>> +++ b/drivers/platform/x86/acer-wmi.c
>>> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = {
>>> {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
>>> {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>>> {KE_KEY, 0x86, {KEY_WLAN} },
>>> + {KE_KEY, 0x87, {KEY_POWER} },
>>> {KE_END, 0}
>>> };
>>>
>>>
>> Limited to specific x86 platform, regression potential low. Can this be
>> upstreamed at some point?
>>
>> Acked-by: Colin Ian King <colin.king at canonical.com>
>
> It is in the process of being upstream by the patch Author.
>
That's good to know, thanks!
More information about the kernel-team
mailing list