NACK/cmnt: [kteam-tools][PATCH] cranky-test-build: Make the positional arg 'arch' an optional arg

Juerg Haefliger juerg.haefliger at canonical.com
Thu Apr 26 13:07:10 UTC 2018


>> -if [ -z "${arches}" ] ; then
>> +if [ "${arches[0]}" = "all" ] ; then
>>  	# shellcheck disable=SC2012
>>  	arches=$(ls -d debian.master/config/*/ | sed -e 's,/$,,' -e 's,.*/,,' | \
>>  				 tr '\n' ' ')
> 
> This will create an array with a single element, and since below it's
> now iterated as 'for arch in "${arches[@]}"', providing '-a all' doesn't
> work anymore:

Ah, good catch. v2 coming up.

...Juerg




More information about the kernel-team mailing list