ACK/cmnt: [SRU][Xenial][PATCH] UBUNTU: ubuntu: i915_bpo - Add MODULE_FIRMWARE for Geminilake's DMC

[Seth Forshee]

On Wed, Apr 25, 2018 at 08:44:24AM +0200, Juerg Haefliger wrote:
> On 04/24/2018 06:18 PM, Seth Forshee wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1752536
> > 
> > We ship this firmware but it fails to load because it is not
> > present in the initrd. Add a MODULE_FIRMWARE statement to fix
> > this.
> > 
> > Signed-off-by: Seth Forshee <seth.forshee at canonical.com>
> > ---
> >  ubuntu/i915/intel_csr.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/ubuntu/i915/intel_csr.c b/ubuntu/i915/intel_csr.c
> > index 91eb151242a1..2b3b428d9cd2 100644
> > --- a/ubuntu/i915/intel_csr.c
> > +++ b/ubuntu/i915/intel_csr.c
> > @@ -42,6 +42,7 @@
> >   */
> >  
> >  #define I915_CSR_KBL "i915/kbl_dmc_ver1.bin"
> > +MODULE_FIRMWARE(I915_CSR_KBL);
> >  #define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
> 
> Acked-by: Juerg Haefliger <juergh at canonical.com>
> 
> but hat firmware blob seems to missing in linux-firmware in Xenial. Or
> am I looking in the wrong place?

It looks like it's there to me (albeit as a symlink), should be in
/lib/firmware/i915.

Seth