[SRU][Trusty][PATCH 1/1] mm/madvise.c: fix madvise() infinite loop under special circumstances

Kleber Sacilotto de Souza kleber.souza at canonical.com
Fri Apr 20 12:50:15 UTC 2018

From: chenjie <chenjie6 at huawei.com>


MADVISE_WILLNEED has always been a noop for DAX (formerly XIP) mappings.
Unfortunately madvise_willneed() doesn't communicate this information
properly to the generic madvise syscall implementation.  The calling
convention is quite subtle there.  madvise_vma() is supposed to either
return an error or update &prev otherwise the main loop will never
advance to the next vma and it will keep looping for ever without a way
to get out of the kernel.

It seems this has been broken since introduction.  Nobody has noticed
because nobody seems to be using MADVISE_WILLNEED on these DAX mappings.

[mhocko at suse.com: rewrite changelog]
Link: http://lkml.kernel.org/r/20171127115318.911-1-guoxuenan@huawei.com
Fixes: fe77ba6f4f97 ("[PATCH] xip: madvice/fadvice: execute in place")
Signed-off-by: chenjie <chenjie6 at huawei.com>
Signed-off-by: guoxuenan <guoxuenan at huawei.com>
Acked-by: Michal Hocko <mhocko at suse.com>
Cc: Minchan Kim <minchan at kernel.org>
Cc: zhangyi (F) <yi.zhang at huawei.com>
Cc: Miao Xie <miaoxie at huawei.com>
Cc: Mike Rapoport <rppt at linux.vnet.ibm.com>
Cc: Shaohua Li <shli at fb.com>
Cc: Andrea Arcangeli <aarcange at redhat.com>
Cc: Mel Gorman <mgorman at techsingularity.net>
Cc: Kirill A. Shutemov <kirill.shutemov at linux.intel.com>
Cc: David Rientjes <rientjes at google.com>
Cc: Anshuman Khandual <khandual at linux.vnet.ibm.com>
Cc: Rik van Riel <riel at redhat.com>
Cc: Carsten Otte <cotte at de.ibm.com>
Cc: Dan Williams <dan.j.williams at intel.com>
Cc: <stable at vger.kernel.org>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
(backported from commit 6ea8d958a2c95a1d514015d4e29ba21a8c0a1a91)
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
 mm/madvise.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/madvise.c b/mm/madvise.c
index 539eeb96b323..08f7501b57d0 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -221,9 +221,9 @@ static long madvise_willneed(struct vm_area_struct *vma,
 	struct file *file = vma->vm_file;
+	*prev = vma;
 	if (!file || mapping_cap_swap_backed(file->f_mapping)) {
-		*prev = vma;
 		if (!file)
 			force_swapin_readahead(vma, start, end);
@@ -241,7 +241,6 @@ static long madvise_willneed(struct vm_area_struct *vma,
 		return 0;
-	*prev = vma;
 	start = ((start - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
 	if (end > vma->vm_end)
 		end = vma->vm_end;

More information about the kernel-team mailing list