ACK: [PATCH Bionic/Unstable] UBUNTU: SAUCE: usb: typec: ucsi: Increase command completion timeout value
Colin Ian King
colin.king at canonical.com
Fri Apr 13 13:46:11 UTC 2018
On 13/04/18 10:54, Thadeu Lima de Souza Cascardo wrote:
> From: Heikki Krogerus <heikki.krogerus at linux.intel.com>
>
> BugLink: http://bugs.launchpad.net/bugs/1758797
>
> On some boards, under heavy load, the EC firmware is
> unable to complete commands even in one second. Increasing
> the command completion timeout value to five seconds.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Cc: <stable at vger.kernel.org>
> Signed-off-by: Heikki Krogerus <heikki.krogerus at linux.intel.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
> ---
> drivers/usb/typec/ucsi/ucsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 79046fe66426..8d95b3a168d2 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -28,7 +28,7 @@
> * difficult to estimate the time it takes for the system to process the command
> * before it is actually passed to the PPM.
> */
> -#define UCSI_TIMEOUT_MS 1000
> +#define UCSI_TIMEOUT_MS 5000
>
> /*
> * UCSI_SWAP_TIMEOUT_MS - Timeout for role swap requests
>
Upstream fix, seems very reasonable to me, minimal regression potential.
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the kernel-team
mailing list