[PATCH 0/1] [Zesty] [V2] Add new trackpoint device ID

Aaron Ma aaron.ma at canonical.com
Thu Sep 28 01:57:45 UTC 2017

On 09/28/2017 03:14 AM, Stefan Bader wrote:
> On 27.09.2017 04:43, Aaron Ma wrote:
>> BugLink: https://launchpad.net/bugs/1715271
>> [Impact]
>> Trackpoint is not recognized on Thinkpad X1 Carbon/Yoga.
>> It is shown as PS/2 common device.
>> [Fix]
>> Add device ID when detect it.
>> [Test Case]
>> xinput show:
>> TPPS/2 IBM TrackPoint
>> [Regression Potential]
>> Very low.
>> Add new ID to support new device.
>> This patch had been merged to xenial kernel, but not in Zesty.
>> And it is already in Artful kernel.
>> So please apply it in Zesty only.
>> Aaron Ma (1):
>>   Input: trackpoint - add new trackpoint firmware ID
>>  drivers/input/mouse/trackpoint.c | 3 ++-
>>  drivers/input/mouse/trackpoint.h | 3 ++-
>>  2 files changed, 4 insertions(+), 2 deletions(-)
> The patch looks ok'ish but why is the Zesty task of the bug report set to fix
> committed? That would only be true if it was applied to the git tree.

There are two patches need to be applied on Zesty. I sent the patch:
commit d1cc4ec84d1343646de15e87f7229e643ea3f75f
Author: Oscar Campos <oscar.campos at member.fsf.org>
Date:   Wed Sep 6 06:29:00 2017 +0200

    Input: trackpoint - assume 3 buttons when buttons detection fails

    BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1715271

    Trackpoint buttons detection fails on ThinkPad 570 and 470 series,
    this makes the middle button of the trackpoint to not being recogized.
    As I don't believe there is any trackpoint with less than 3 buttons this
    patch just assumes three buttons when the extended button information
    read fails.

    Signed-off-by: Oscar Campos <oscar.campos at member.fsf.org>
    Acked-by: Peter Hutterer <peter.hutterer at who-t.net>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
    (backported from commit 293b915fd9bebf33cdc906516fb28d54649a25ac)
    Signed-off-by: Aaron Ma <aaron.ma at canonical.com>
    Acked-by: Seth Forshee <seth.forshee at canonical.com>
    Acked-by: Hui Wang <hui.wang at canonical.com>
    Signed-off-by: Stefan Bader <stefan.bader at canonical.com>

That's why the bug is set as fix committed.

This patch is on stable kernel 4.4/4.9/4.12, but not Zesty.
So I send this patch here.

Sorry for any inconvenience.


> -Stefan

More information about the kernel-team mailing list