NACK: [pull] [SRU][Zesty]PCI: Add pci_mmap_resource_range() and use it for ARM64

[Stefan Bader]

On 20.09.2017 16:20, Manoj Iyer wrote:
> Please review and consider this pull request for Zesty to address bug
> https://launchpad.net/bugs/1712580 where without this patch uio device binding
> inside VM would fail with errors. This patch was requested by Qualcomm for their
> QDF2400 system. The test kernel is available at 
> https://launchpad.net/~centriq-team/+archive/ubuntu/lp1712580/ and was tested by
> me on QDF2400 system. The patches touch PCI subsystem on all architecures and
> PCI drivers, I have regression tested it on AMD64 and PPC64EL systems and posted
> those results to the bug report. 
> 
> The following changes since commit 6b7134e0ebc3750d3cbae0fec2ad9e032264b836:
> 
>   UBUNTU: Ubuntu-4.10.0-33.37 (2017-08-11 11:41:50 +0200)
> 
> are available in the git repository at:!
> 
>   git+ssh://git.launchpad.net/~centriq-team/+git/linux-sru:lp1712580 
> 
> for you to fetch changes up to d08ceb5769af1059d87e9df000cecfa743c81a85:
> 
>   PCI: Add pci_mmap_resource_range() and use it for ARM64 (2017-08-24 11:28:13
> -0500)
> 
> ----------------------------------------------------------------
> David Woodhouse (4):
>       PCI: Move multiple declarations of pci_mmap_page_range() to <linux/pci.h>
>       PCI: Use BAR index in sysfs attr->private instead of resource pointer
>       PCI: Add BAR index argument to pci_mmap_page_range()
>       PCI: Add pci_mmap_resource_range() and use it for ARM64
> 
>  Documentation/filesystems/sysfs-pci.txt | 10 ++--
> &n! bsp;arch/ arm/include/asm/pci.h              |  2 -
>  arch/arm/kernel/bios32.c                |  3 +-
>  arch/arm64/include/asm/pci.h            |  2 +
>  arch/cris/arch-v32/drivers/pci/bios.c   |  3 +-
>  arch/cris/include/asm/pci.h             |  3 --
>  arch/ia64/include/asm/pci.h             |  4 +-
>  arch/ia64/pci/pci.c                     |  3 +-
>  arch/microblaze/include/asm/pci.h       |  3 --
>  arch/microblaze/pci/pci-common.c        |  2 +-
>  arch/mips/include/asm/pci.h             |  3 --
>  arch/mips/pci/pci.c !   &n bsp;                 |  3 +-
>  arch/mn10300/include/asm/pci.h          |  3 --
>  arch/mn10300/unit-asb2305/pci-asb2305.c |  3 +-
>  arch/parisc/include/asm/pci.h           |  3 --
>  arch/parisc/kernel/pci.c                |  3 +-
>  arch/powerpc/include/asm/pci.h          |  3 --
>  arch/powerpc/kernel/pci-common.c        |  3 +-
>  arch/sh/drivers/pci/pci.c               |  3 +-
>  arch/sh/include/asm/pci.h               |  3 +-
>  arch/sparc/include/asm/pci_64.h         |  4 --
>  arch/sparc/kernel/pci.c         !   &n bsp;     |  6 +--
>  arch/unicore32/include/asm/pci.h        |  2 -
>  arch/unicore32/kernel/pci.c             |  3 +-
>  arch/x86/include/asm/pci.h              |  5 +-
>  arch/x86/pci/i386.c                     |  3 +-
>  arch/xtensa/include/asm/pci.h           |  4 --
>  arch/xtensa/kernel/pci.c                |  3 +-
>  drivers/pci/Makefile                    |  2 +-
>  drivers/pci/mmap.c                      | 95 +++++++++++++++++++++++++++++++++
>  drivers/pci/pci-sysfs.c          ! ;       | 52 ++++++------------
>  drivers/pci/pci.h                       |  4 +-
>  drivers/pci/proc.c                      |  2 +-
>  include/linux/pci.h                     | 23 ++++++++
>  34 files changed, 177 insertions(+), 96 deletions(-)
>  create mode 100644 drivers/pci/mmap.c
> 
> 
> 
These changes are spreading across all arches, touching a central subsystem. If
this really needs to be fixed in the Zesty kernel, there should be a more
minimalistic approach. Otherwise I would say this will be fixed once the Artful
kernel becomes the current HWE kernel.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170927/77f441fb/attachment.sig>