ACK / APPLIED[artful]: [SRU][Zesty][PATCH 1/1] scsi: cxlflash: Fix vlun resize failure in the shrink path
Seth Forshee
seth.forshee at canonical.com
Thu Sep 21 19:22:58 UTC 2017
On Wed, Sep 20, 2017 at 11:47:50AM -0400, Joseph Salisbury wrote:
> From: Uma Krishnan <ukrishn at linux.vnet.ibm.com>
>
> BugLink: http://bugs.launchpad.net/bugs/1713575
>
> The ioctl DK_CAPI_VLUN_RESIZE can fail if the allocated vlun size is
> reduced from almost maximum capacity and then increased again.
>
> The shrink_lxt() routine is currently using the SISL_ASTATUS_MASK to
> mask the higher 48 bits of the lxt entry. This is unnecessary and
> incorrect as it uses a mask designed for the asynchronous interrupt
> status register. When the 4 port support was added to cxlflash, the
> SISL_ASTATUS_MASK was updated to reflect the status bits for all 4
> ports. This change indirectly affected the shrink_lxt() code path.
>
> To extract the base, simply shift the bits without masking.
>
> Fixes: 565180723294 ("scsi: cxlflash: SISlite updates to support 4 ports")
> Signed-off-by: Uma Krishnan <ukrishn at linux.vnet.ibm.com>
> Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
> (cherry picked from commit 07a191f762a7b8d0db13c38036380927116e29bb)
> Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
Clean cherry pick, positive testing.
Acked-by: Seth Forshee <seth.forshee at canonical.com>
Applied to artful/master-next, thanks.
More information about the kernel-team
mailing list