ACK/cmnt: [kteam-tools][PATCH] wfl/bug.py: change the way to detect when to use esm ppa

[Po-Hsu Lin (Sam)]

On Fri, Sep 15, 2017 at 6:15 PM, Stefan Bader
<stefan.bader at canonical.com> wrote:
> On 15.09.2017 11:37, Po-Hsu Lin wrote:
>> Both Precise and Trusty HWE kernel are running on series Precise.
>> Use this as a better criteria, since the old if statement does not
>> work for Precise kernel, there is no package called precise.
>>
>> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
>
>> ---
>
> It sounds sensible. Personally it would help me to have a quick explanation
> about how this breaks things.

For T-hwe, the old method is good as the package name is
'linux-lts-trusty', but for Precise, the package name is 'linux'.
So I guess it's a typo for s.pkg_name in ['precise'] here, which
should be s.series in ['precise']

And this can be trimmed down to just check the series. As they both
run on Precise.

>
> Thanks,
> Stefan
>
>>  stable/wfl/bug.py | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/stable/wfl/bug.py b/stable/wfl/bug.py
>> index 632cbc05..f897a139 100644
>> --- a/stable/wfl/bug.py
>> +++ b/stable/wfl/bug.py
>> @@ -847,12 +847,12 @@ class WorkflowBug():
>>
>>          if ppa:
>>              msg['pocket'] = 'ppa'
>> -            if s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:
>> +            if s.series in ['precise']:
>>                  msg['ppa'] = 'ppa:canonical-kernel-esm/ppa'
>>              else:
>>                  msg['ppa'] = 'ppa:canonical-kernel-team/ppa'
>>              msg['key']    = 'kernel.published.ppa.%s' % s.series
>> -        elif s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:
>> +        elif s.series in ['precise']:
>>              msg['pocket'] = 'ppa'
>>              msg['ppa']    = 'ppa:canonical-kernel-esm/proposed'
>>              msg['key']    = 'kernel.published.ppa.%s' % s.series
>>
>
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>