ACK: [SRU][Vivid][PATCH 0/1] CIFS: Fix maximum SMB2 header size

Colin Ian King colin.king at canonical.com
Mon Sep 11 13:30:15 UTC 2017


On 08/09/17 14:09, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1713884
> 
> == SRU Justification ==
> Currently the maximum size of SMB2/3 header is set incorrectly which
> leads to hanging of directory listing operations on encrypted SMB3
> connections. Fix this by setting the maximum size to 170 bytes that
> is calculated as RFC1002 length field size (4) + transform header
> size (52) + SMB2 header size (64) + create response size (56).
> 
> This bug is fixed by commit 9e37b1784f2be9397a903307574ee565bbadfd75 which is in 
> mainline as of 4.13 final.
> 
> Commit 9e37b1784f2b is needed in X, Z and A as well.  However, there are context diffs
> from Vivid, so their SRUs will be sent separatly.
> 
> 
> == Fix ==
> commit 9e37b1784f2be9397a903307574ee565bbadfd75
> Author: Pavel Shilovsky <pshilov at microsoft.com>
> Date:   Thu Aug 24 15:16:40 2017 -0700
> 
>     CIFS: Fix maximum SMB2 header size
> 
> == Regression Potential ==
> Patch is specific to to CIFS and only increases MAX_SMB2_HDR_SIZE.
> 
> Patch submitted to kernel stable trees, so it will also be reivewed by a wider audience 
> upstream.
> 
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> Pavel Shilovsky (1):
>   CIFS: Fix maximum SMB2 header size
> 
>  fs/cifs/smb2pdu.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the kernel-team mailing list