[PATCH 1/1] [SRU Artful] Input: trackpoint - assume 3 buttons when buttons detection fails

Aaron Ma aaron.ma at canonical.com
Wed Sep 6 04:29:34 UTC 2017

From: Oscar Campos <oscar.campos at member.fsf.org>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1715271

Trackpoint buttons detection fails on ThinkPad 570 and 470 series,
this makes the middle button of the trackpoint to not being recogized.
As I don't believe there is any trackpoint with less than 3 buttons this
patch just assumes three buttons when the extended button information
read fails.

Signed-off-by: Oscar Campos <oscar.campos at member.fsf.org>
Acked-by: Peter Hutterer <peter.hutterer at who-t.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
(cherry-picked from commit 293b915fd9bebf33cdc906516fb28d54649a25ac)
Signed-off-by: Aaron Ma <aaron.ma at canonical.com>
 drivers/input/mouse/trackpoint.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
index 922ea02edcc3..20b5b21c1bba 100644
--- a/drivers/input/mouse/trackpoint.c
+++ b/drivers/input/mouse/trackpoint.c
@@ -380,8 +380,8 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
 		return 0;
 	if (trackpoint_read(ps2dev, TP_EXT_BTN, &button_info)) {
-		psmouse_warn(psmouse, "failed to get extended button data\n");
-		button_info = 0;
+		psmouse_warn(psmouse, "failed to get extended button data, assuming 3 buttons\n");
+		button_info = 0x33;
 	psmouse->private = kzalloc(sizeof(struct trackpoint_data), GFP_KERNEL);

More information about the kernel-team mailing list