ACK: [SRU][Zesty][PATCH 1/1] powerpc: Drop GPL from of_node_to_nid() export to match other arches

Colin Ian King colin.king at canonical.com
Tue Sep 5 10:18:25 UTC 2017


On 01/09/17 16:53, Joseph Salisbury wrote:
> From: Shailendra Singh <shailendras at nvidia.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1709179
> 
> The generic implementation of of_node_to_nid() is EXPORT_SYMBOL, added
> in commit 298535c00a2c ("of, numa: Add NUMA of binding
> implementation.").
> 
> The powerpc implementation added in commit 953039c8df7b ("[PATCH]
> powerpc: Allow devices to register with numa topology") is
> EXPORT_SYMBOL_GPL.
> 
> This creates an inconsistency for of_node_to_nid() callers across
> architectures.
> 
> Update the powerpc implementation to be exported consistently with the
> generic implementation.
> 
> Signed-off-by: Shailendra Singh <shailendras at nvidia.com>
> Reviewed-by: Andy Ritger <aritger at nvidia.com>
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
> (cherry picked from commit be9ba9ff93cc3e44dc46da9ed25655780069411a)
> Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
> ---
>  arch/powerpc/mm/numa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index b1099cb..8aa4ca3 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -290,7 +290,7 @@ int of_node_to_nid(struct device_node *device)
>  
>  	return nid;
>  }
> -EXPORT_SYMBOL_GPL(of_node_to_nid);
> +EXPORT_SYMBOL(of_node_to_nid);
>  
>  static int __init find_min_common_depth(void)
>  {
> 

Clean cherry pick, limit regression potential. looks good to me.

Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the kernel-team mailing list