[Artful][PATCH 3/3] UBUNTU: SAUCE: ASoC: rt5670: Add support for Wyse 3040

Jesse Sung jesse.sung at canonical.com
Mon Oct 16 15:02:31 UTC 2017

On Mon, Oct 16, 2017 at 10:50 PM, Seth Forshee
<seth.forshee at canonical.com> wrote:
> On Mon, Oct 16, 2017 at 07:27:00PM +0800, Wen-chien Jesse Sung wrote:
>> @@ -2890,6 +2919,13 @@ static int rt5670_i2c_probe(struct i2c_client *i2c,
>>               rt5670->pdata.jd_mode = 2;
>>       }
>> +     pdev_host = pci_get_subsys(0x8086, 0x2280, 0x1028, 0x07c1, NULL);
> What device do these pci ids represent exactly? I mean, no doubt they
> represent something specific to the machine you're looking for, just
> wondering what exactly.

These are the PCI IDs/subsys-IDs of the host PCI bridge.

> This seems like a pretty hacky way to determine whether these "quirks"
> are needed. Is there no more direct way to figure this out? I won't
> object to this if there isn't, but I want to be convinced.

Yes I agree this is pretty hacky. Since it's an I2C device, there's no clues
like PCI subsys IDs. DMI strings may be a way to do that, but the systems
may be re-branded so that DMI IDs are not reliable in this case...


More information about the kernel-team mailing list