[kteam-tools][PATCH] link-to-tracker: add a --re-run commandline option
Juerg Haefliger
juerg.haefliger at canonical.com
Fri Oct 13 06:08:17 UTC 2017
On 10/12/2017 05:40 PM, Andy Whitcroft wrote:
> On Thu, Oct 12, 2017 at 04:59:13PM +0200, Juerg Haefliger wrote:
>> Sometimes it's desirable or necessary to re-run link-to-tracker. Currently
>> the script bails out if the title of the tracking bug doesn't contain
>> the string '<version to be filled>' which means the script ran already.
>> This new commandline option will bypass that check.
>>
>> Signed-off-by: Juerg Haefliger <juerg.haefliger at canonical.com>
>> ---
>> stable/link-to-tracker | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/stable/link-to-tracker b/stable/link-to-tracker
>> index 9f4796753bd2..bb31d97391a8 100755
>> --- a/stable/link-to-tracker
>> +++ b/stable/link-to-tracker
>> @@ -179,7 +179,7 @@ class Tracking():
>> found = []
>> for (bugid, tasks_by_name) in found_tasks:
>> lpbug = s.launchpad.bugs[bugid]
>> - if '<version to be filled>' not in lpbug.title:
>> + if not s.args.re_run and '<version to be filled>' not in lpbug.title:
>> continue
>
> Should this rather check if the version is <xxxx> _or_ is the version we
> are expecting ?
I also had wrong versions in the title that needed cleaning up. I'd
rather not check for a specific version unless this generic override can
have other unwanted side effects.
...Juerg
>> if s.args.sru_cycle and s.bug_to_sru_cycle(lpbug) != s.args.sru_cycle:
>> continue
>> @@ -260,6 +260,7 @@ if __name__ == '__main__':
>> parser.add_argument('--info', action='store_true', default=False, help='')
>> parser.add_argument('--debug', action='store_true', default=False, help='')
>> parser.add_argument('--dry-run', action='store_true', default=False, help='')
>> + parser.add_argument('--re-run', action='store_true', default=False, help='')
>> parser.add_argument('--sru-cycle', action='store', help='')
>> args = parser.parse_args()
>
> -apw
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 845 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20171013/08e941f9/attachment.sig>
More information about the kernel-team
mailing list