NACK: [PATCH 0/3] UBUNTU: SAUCE: opennsl: fix static analysis issues

Thadeu Lima de Souza Cascardo cascardo at
Mon Oct 9 18:30:13 UTC 2017

On Wed, Sep 20, 2017 at 11:27:04AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king at>
> Static analysis with CoverityScan on the opennsl driver has picked up 2
> sets of bugs and some redundant code. The following 3 patches address
> these issues to make the driver static analysis clean.
> BugLink:
> Colin Ian King (3):
>   opennsl: bcm-knet: check for null sinfo to avoid a null pointer
>     dereference
>   opennsl: bcm-knet: remove redundant null checks on dev->name
>   opennsl: bde: check for out-of-bounds index
>  .../systems/bde/linux/user/kernel/linux-user-bde.c | 42 ++++++++++++++++++++++
>  .../linux/kernel/modules/bcm-knet/bcm-knet.c       |  7 ++--
>  2 files changed, 46 insertions(+), 3 deletions(-)

The OpenNSL driver has received an update, and not only paths have
changed, but code as well. Even though I managed to apply and resolve
conflicts for this series, I think it's better to try to send this
upstream so next OpenNSL updates will not only have those fixes applied
already, but we won't have to deal with new conflicts.

So, I am leaving this out of this cycle for now. Can you try to get
those applied upstream, then?


More information about the kernel-team mailing list