ACK/cmnt: [SRU][Zesty][PATCH 0/3] Fixes for LP:1721070

Stefan Bader stefan.bader at canonical.com
Mon Oct 9 09:10:10 UTC 2017


On 06.10.2017 19:36, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1721070
> 
> == SRU Justification ==
> POWER9 DD2.1 and earlier has an issue where some cache inhibited
> vector load will return bad data. The fix is two part, one
> firmware/microcode part triggers HMI interrupts when hitting such
> loads, the other part is commit 5080332c2c89 from linux-next which then
> emulates the instructions in Linux.
> 
> The affected instructions are limited to lxvd2x, lxvw4x, lxvb16x and
> lxvh8x.
> 
> Commits a3d96f70c147 and ccd3cd361341 are needed as prereqs.
> Commit 5080332c2c89 is still in linux-next. 
> 
> An SRU request as also sent for Artful, but it did not need a3d96f70c147.
> 
> == Fixes ==
> a3d96f70c147 ("powerpc/64s: Fix system reset vs general interrupt reentrancy")
> ccd3cd361341 ("powerpc/mce: Move 64-bit machine check code into mce.c")
> 5080332c2c89 ("powerpc/64s: Add workaround for P9 vector CI load issue")
> 
> == Regression Potential ==
> These commits are specific to powerpc.  They required some back porting but
>  have been tested by IBM.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> 
> Michael Ellerman (1):
>   powerpc/mce: Move 64-bit machine check code into mce.c
> 
> Michael Neuling (1):
>   powerpc/64s: Add workaround for P9 vector CI load issue
> 
> Nicholas Piggin (1):
>   powerpc/64s: Fix system reset vs general interrupt reentrancy
> 
>  arch/powerpc/include/asm/emulated_ops.h  |   4 +
>  arch/powerpc/include/asm/exception-64s.h |  14 +-
>  arch/powerpc/include/asm/paca.h          |   9 +-
>  arch/powerpc/include/asm/reg.h           |   1 +
>  arch/powerpc/include/asm/uaccess.h       |  17 +++
>  arch/powerpc/kernel/asm-offsets.c        |   1 +
>  arch/powerpc/kernel/exceptions-64s.S     |  25 +++-
>  arch/powerpc/kernel/mce.c                |  61 ++++++++
>  arch/powerpc/kernel/traps.c              | 236 ++++++++++++++++++++++++++-----
>  arch/powerpc/platforms/powernv/smp.c     |   7 +
>  10 files changed, 324 insertions(+), 51 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

Patch #3 is really ugly, but ok, good testing at least and isolated to the one arch.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20171009/5dfecb03/attachment.sig>


More information about the kernel-team mailing list