Tentative-NACK: [Pull] [Zesty SRU] Enable TCG_CRB for ARM64.

Manoj Iyer manoj.iyer at canonical.com
Fri Oct 6 13:22:06 UTC 2017


On Fri, 6 Oct 2017, Stefan Bader wrote:

> On 18.09.2017 16:43, Manoj Iyer wrote:
>> Please consider the following pull request for Zesty to enable TCG_CRB for
>> ARM64. This module support is required on QDF2400 ARM64 platforms. A test kernel
>> for this bug https://bugs.launchpad.net/bugs/1716033 was tested by QTI and
>> reported to work. 
>>
>>
>> The following changes since commit 1bfb6eb7ecd64066f0ff2e2a5990ac6bbded1816:
>>
>>   UBUNTU: Ubuntu-4.10.0-34.38 (2017-08-28 10:41:02 -0300)
>>
>> are available in the git repository at:
>>
>>   git+ssh://git.launchpad.net/~centriq-team/+git/linux-sru:lp1716033-v1 
>>
>> for you to fetch changes up to fbd45e3e333cb6724f61c1f90013eb5323a0efab:
>>
>>   [Config] Enable TCG_CRB for ARM64. (2017-09-18 08:! 25:10 -05 00)
>>
>> ----------------------------------------------------------------
>> Jarkko Sakkinen (3):
>>       tpm_crb: map locality registers
>>       tpm_crb: encapsulate crb_wait_for_reg_32
>>       tpm_crb: remove a cruft constant
>>
>> Jason Gunthorpe (1):
>>       tpm crb: Work around BIOS's that report the wrong ACPI region size
>>
>> Jerry Snitselaar (1):
>>       tpm_crb: check for bad response size
>>
>> Jiandi An (2):
>>       tpm, tpm_crb: Handle 64-bit resource in crb_check_resource()
>>       tpm/tpm_crb: Enable TPM CRB interface for ARM64
>>
>> Manoj Iyer (1):
>>       [Config] Enable TCG_CRB for ARM64.
>>
>>  debian.master/config/annotations | 2 +-
>> &nbs! p;drivers /char/tpm/Kconfig | 2 +-
>>  drivers/char/tpm/tpm_crb.c | 218 ++++++++++++++++++++++++++++++---------
>>  include/acpi/actbl2.h | 1 +
>>  4 files changed, 172 insertions(+), 51 deletions(-)
>>
>>
>>
> Unless someone else has strong opinions: my gut feeling is that this is more of
> an enablement / feature. And with Artful release coming soon and Zesty support
> ending not that soon after, I think efforts of adding features should rather
> target the Artful kernel.
>
> -Stefan
>
>

Stefan,

Thanks for reviewing this pull request. I will make sure these patches are 
in the Artful kernel.

--
============================
Manoj Iyer
Ubuntu/Canonical
ARM Servers - Cloud
============================


More information about the kernel-team mailing list