ACK: [SRU][Xenial][PATCH 0/4] Fixes for LP:1693369

[Colin Ian King]

On 20/09/17 20:12, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1693369
> 
> == SRU Justification ==
> This bug is resolved by commits 62e62ffd95539b9220894a7900a619e0f3ef4756 and
> commit 9373eba6cfae48911b977d14323032cd5d161aae.  The first commit, 62e62ffd95,
> was already applied to Xenial with the 4.4.79 updates.
> 
> Without these patches, the symlink in sysfs which binds a SAS device to an enclosure 
> slot does not get created. This makes disk hotplug near impossible on large 
> JBOD disk drawers.
> 
> There are three prereq commits in order to apply commit 9373eba6c to Xenial.  Those
> commits are listed in the 'Fixes' section of this SRU request.
> 
> This fix is also needed in Zesty, but that SRU was sent separately because Zesty
> required only commit 62e62ffd95.
> 
> 
> == Fixes ==
> Prereq:
> commit bcf508c13385e74972f5cc06d8471d5c100395b0
> Author: James Bottomley <James.Bottomley at HansenPartnership.com>
> Date:   Wed Dec 9 11:13:35 2015 -0800
> 
>     scsi_transport_sas: add function to get SAS endpoint address
> 
> Prereq:
> commit 3f8d6f2a0797e8c650a47e5c1b5c2601a46f4293
> Author: James Bottomley <James.Bottomley at HansenPartnership.com>
> Date:   Wed Dec 9 12:56:07 2015 -0800
> 
>     ses: fix discovery of SATA devices in SAS enclosures
> 
> Prereq:
> commit c1a23f6d64552b4480208aa584ec7e9c13d6d9c3
> Author: Johannes Thumshirn <jthumshirn at suse.de>
> Date:   Wed Aug 17 11:46:16 2016 +0200
> 
>     scsi: sas: provide stub implementation for scsi_is_sas_rphy
>     
> Real fix:
> commit 9373eba6cfae48911b977d14323032cd5d161aae
> Author: Ewan D. Milne <emilne at redhat.com>
> Date:   Mon Jan 9 16:33:36 2017 -0500
> 
>     scsi: ses: Fix SAS device detection in enclosure
> 
> 
> == Regression Potential ==
> There are four required patchs, so there is a medium regression potention.  However,
> the patch set was tested by IBM and confirmed to resolve the bug without causing
> other issues. 
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Ewan D. Milne (1):
>   scsi: ses: Fix SAS device detection in enclosure
> 
> James Bottomley (2):
>   scsi_transport_sas: add function to get SAS endpoint address
>   ses: fix discovery of SATA devices in SAS enclosures
> 
> Johannes Thumshirn (1):
>   scsi: sas: provide stub implementation for scsi_is_sas_rphy
> 
>  drivers/scsi/Kconfig              |  1 +
>  drivers/scsi/scsi_transport_sas.c | 14 ++++++++++++++
>  drivers/scsi/ses.c                | 22 ++++------------------
>  include/scsi/scsi_transport_sas.h | 17 ++++++++++++++++-
>  4 files changed, 35 insertions(+), 19 deletions(-)
> 

Testing looks good.

Acked-by: Colin Ian King <colin.king at canonical.com>