[SRU][T][PATCH 0/2] LP#1729119: NVMe timeout parameter type change

Daniel Axtens daniel.axtens at canonical.com
Tue Nov 21 09:03:47 UTC 2017


BugLink: https://bugs.launchpad.net/bugs/1729119

[SRU Justification]

[Impact]
Some NVMe operations time out too quickly. The module parameters allow
the timeouts to be extended, but only up to 255s, as the counters are
bytes.

[Fix]
The underlying parameters are unsigned ints, so make the module
parameters unsigned ints too, by picking patch
http://lists.infradead.org/pipermail/linux-nvme/2017-September/012701.html

(Trusty specific) This also requires picking the patch that converts
the constant into a parameter, which is a clean cherry-pick.

[Regression Potential]
(Trusty specific) Limited: a module parameter is added and its type is
changed. The patches are easily reviewable.

[Testing]
(Trusty only) Boot tested on a c5.large instance on AWS which uses
NVMe to boot. Verified that the system still boots with the patches,
and that a timeout of 123456s is permitted.

Keith Busch (1):
  NVMe: Make I/O timeout a module parameter

Marc Olson (1):
  nvme: update timeout module parameter type

 drivers/block/nvme-core.c | 5 +++++
 include/linux/nvme.h      | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

-- 
2.11.0





More information about the kernel-team mailing list