ACK/cmnt: [linux-oem][PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc274

[Stefan Bader]

On 13.11.2017 05:01, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1731822
> 
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
> 
> Cc: <stable at vger.kernel.org>
> Cc: Kailang Yang <kailang at realtek.com>
> Signed-off-by: Hui Wang <hui.wang at canonical.com>
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <hui.wang at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>

> ---

Looks sensible to me. Note that I think the bug should have been filed against
linux-oem (I changed that) and with a xenial task (probably should have
nominated before flipping the package...

-Stefan
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 217bb58..ba48ffa 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x14, 0x90170110},
>  		{0x1b, 0x90a70130},
>  		{0x21, 0x03211020}),
> +	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0xb7a60130},
> +		{0x13, 0xb8a61140},
> +		{0x16, 0x90170110},
> +		{0x21, 0x04211020}),
>  	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>  		{0x12, 0x90a60130},
>  		{0x14, 0x90170110},
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20171120/30eb37f9/attachment.sig>