ACK/cmnt: [PATCH Xenial 00/11] CVE-2015-8952

[Stefan Bader]

On 16.11.2017 17:17, Thadeu Lima de Souza Cascardo wrote:
> Besides the patches that introduce mbcache2 and use it on ext2 and ext4, some
> followups that are referred in some of the CVE links were backported as well.
> 
> I have tested a xattr stress tool without the patches, which caused hangs. With
> the patches, no hangs were seen, and the system was stable during the tests.
> 
> Andreas Gruenbacher (3):
>   ext4: kill ext4_mballoc_ready
>   mbcache: get rid of _e_hash_list_head
>   mbcache: add reusable flag to cache entries
> 
> Jan Kara (8):
>   mbcache2: reimplement mbcache
>   ext2: convert to mbcache2
>   ext4: convert to mbcache2
>   mbcache2: limit cache size
>   mbcache2: Use referenced bit instead of LRU
>   ext4: shortcut setting of xattr to the same value
>   mbcache: remove mbcache
>   mbcache2: rename to mbcache
> 
>  fs/ext2/ext2.h          |    3 +
>  fs/ext2/super.c         |   25 +-
>  fs/ext2/xattr.c         |  139 +++---
>  fs/ext2/xattr.h         |   21 +-
>  fs/ext4/super.c         |   19 +-
>  fs/ext4/xattr.c         |  165 ++++---
>  fs/ext4/xattr.h         |    3 +-
>  fs/mbcache.c            | 1093 +++++++++++++++--------------------------------
>  include/linux/mbcache.h |   93 ++--
>  9 files changed, 577 insertions(+), 984 deletions(-)
> 

While still feeling a bit uneasy due to size, this is proven better by testing.
And doing a quick scan over the rename part I believe that actually the calling
interfaces before and after are the same. So doing the whole change feels
actually safer wrt possible external usage. So...

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20171117/c22c2559/attachment.sig>