ACK/cmnt: [xenial] SRU: [PATCH v2 1/1] Bluetooth: increase timeout for le auto connections
Konrad Zapalowicz
konrad.zapalowicz at canonical.com
Wed Nov 15 14:11:24 UTC 2017
On 11/15, Stefan Bader wrote:
> On 14.11.2017 11:51, Konrad Zapalowicz wrote:
> > From: Konrad Zapałowicz <konrad.zapalowicz at canonical.com>
> >
> > BugLink: https://bugs.launchpad.net/bugs/1731467
> >
> > This patch increases the connection timeout for LE connections that are
> > triggered by the advertising report to 4 seconds.
> >
> > It has been observed that devices equipped with wifi+bt combo SoC fail
> > to create a connection with BLE devices due to their coexistence issues.
> > Increasing this timeout gives them enough time to complete the
> > connection with success.
> >
> > Signed-off-by: Konrad Zapałowicz <konrad.zapalowicz at canonical.com>
> > Signed-off-by: Marcel Holtmann <marcel at holtmann.org>
> > (cherry picked from commit 1f01d8be0e6a04bd682a55f6d50c14c1679e7571 linux-next)
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
>
> > ---
>
> How about at least also targeting this to Artful (and maybe Zesty, too) so that
> this does not break for people switching to HWE kernels?
>From my point of view it is a good idea.
/K
>
> -Stefan
> > include/net/bluetooth/hci.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> > index 0205b80..630f6d7 100644
> > --- a/include/net/bluetooth/hci.h
> > +++ b/include/net/bluetooth/hci.h
> > @@ -266,7 +266,7 @@ enum {
> > #define HCI_AUTO_OFF_TIMEOUT msecs_to_jiffies(2000) /* 2 seconds */
> > #define HCI_POWER_OFF_TIMEOUT msecs_to_jiffies(5000) /* 5 seconds */
> > #define HCI_LE_CONN_TIMEOUT msecs_to_jiffies(20000) /* 20 seconds */
> > -#define HCI_LE_AUTOCONN_TIMEOUT msecs_to_jiffies(2000) /* 2 seconds */
> > +#define HCI_LE_AUTOCONN_TIMEOUT msecs_to_jiffies(4000) /* 4 seconds */
> >
> > /* HCI data types */
> > #define HCI_COMMAND_PKT 0x01
> >
>
>
More information about the kernel-team
mailing list