ACK/cmnt: [Artful][PATCH 00/12] Backport for Power9 Nest PMU Instrumentation

[Gustavo Walbon]

On 15/11/17 11:12, Kleber Souza wrote:
> On 11/02/17 15:04, Gustavo Walbon wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1481347
>>
>> This patchset enable the Power9 Nest PMU Counter to enable it for perf tool.
>>
>> These Nest PMU Counters provide per-chip metrics such memory bandwidth, Powerbus
>> bandwidth and so on.
>>
>> For test it needs Power9 machine with latest version of BMC and the minimum
>> skiboot version v5.9-rc5.
>>
>> Anju T (1):
>>    powerpc/perf/imc: Fix nest events on muti socket system
>>
>> Anju T Sudhakar (6):
>>    powerpc/perf: Add nest IMC PMU support
>>    powerpc/perf: Add core IMC PMU support
>>    powerpc/perf: Add thread IMC PMU support
>>    powerpc/perf: Fix for core/nest imc call trace on cpuhotplug
>>    powerpc/perf: Add ___GFP_NOWARN flag to alloc_pages_node()
>>    powerpc/perf: Fix IMC initialization crash
>>
>> Dan Carpenter (1):
>>    powerpc/perf: Fix double unlock in imc_common_cpuhp_mem_free()
>>
>> LABBE Corentin (1):
>>    powerpc/powernv: Fix build error in opal-imc.c when NUMA=n
>>
>> Madhavan Srinivasan (3):
>>    powerpc/powernv: Add IMC OPAL APIs
>>    powerpc/powernv: Detect and create IMC device
>>    powerpc/perf: Fix usage of nest_imc_refc
>>
>>   arch/powerpc/include/asm/imc-pmu.h             |  128 +++
>>   arch/powerpc/include/asm/opal-api.h            |   12 +-
>>   arch/powerpc/include/asm/opal.h                |    5 +
>>   arch/powerpc/perf/Makefile                     |    1 +
>>   arch/powerpc/perf/imc-pmu.c                    | 1335 ++++++++++++++++++++++++
>>   arch/powerpc/platforms/powernv/Makefile        |    1 +
>>   arch/powerpc/platforms/powernv/opal-imc.c      |  226 ++++
>>   arch/powerpc/platforms/powernv/opal-wrappers.S |    3 +
>>   arch/powerpc/platforms/powernv/opal.c          |   14 +
>>   include/linux/cpuhotplug.h                     |    3 +
>>   10 files changed, 1727 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/powerpc/include/asm/imc-pmu.h
>>   create mode 100644 arch/powerpc/perf/imc-pmu.c
>>   create mode 100644 arch/powerpc/platforms/powernv/opal-imc.c
>>
> As Stefan pointed out, please provide the SRU justification info in the bug.
>
> Apart from that, the changes are limited to powerpc and powerpc/perf and
> are clean cherry picks, so little regression potential.
>
> Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
>
[SRU Justification]
This feature provides the latest core and nest PMU events which it comes 
with the skiboot on Power P9 Arch.

Those patches are available on mainline kernel tree in 
tags/powerpc-4.14-1~314 .

The commit is a clean cherry pick in Artful.

[Testcase]
1 - Verify if the perf has the PMU events available via the latest 
version of skiboot.
# perf list | grep core_imc
# perf list | grep nest_
# perf list | grep thread_imc

2 - Test couple of them like that:
# ./perf stat -e nest_mcs0/PM_MCS_UP_128B_DATA_XFER_MC2/ -a -A sleep 5