[RESEND][SRU][Xenial][PATCH 0/1] ibmveth: Support to enable LSO/CSO for Trunk VEA.

[Joseph Salisbury]

If possible, can this SRU request be reviewed?

Thanks,

Joe



On 08/25/2017 12:23 PM, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1692538
>
> == SRU Justification ==
> Commit 66aa0678ef is request to fix four issues with the ibmveth driver.  
> The issues are as follows:
> - Issue 1: ibmveth doesn't support largesend and checksum offload features when configured as "Trunk".
> - Issue 2: SYN packet drops seen at destination VM. When the packet 
> originates, it has CHECKSUM_PARTIAL flag set and as it gets delivered to IO 
> server's inbound Trunk ibmveth, on validating "checksum good" bits in ibmveth 
> receive routine, SKB's ip_summed field is set with CHECKSUM_UNNECESSARY flag.
> - Issue 3: First packet of a TCP connection will be dropped, if there is 
> no OVS flow cached in datapath.
> - Issue 4: ibmveth driver doesn't have support for SKB's with frag_list.
>
> The details for the fixes to these issues are described in the commits git log.
>
> This fix has already been included in Zesty and Artful, but Xenial required a backport.  
>
> Commit 66aa0678ef is in mainline as of v4.13-rc1.
>
> == Fix ==
> commit 66aa0678efc29abd2ab02a09b23f9a8bc9f12a6c
> Author: Sivakumar Krishnasamy <ksiva at linux.vnet.ibm.com>
> Date:   Fri May 19 05:30:38 2017 -0400
>
>     ibmveth: Support to enable LSO/CSO for Trunk VEA.
>
> == Regression Potential ==
> The changes are specific to the ibmveth driver, so regression risk is low.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
> Sivakumar Krishnasamy (1):
>   ibmveth: Support to enable LSO/CSO for Trunk VEA.
>
>  drivers/net/ethernet/ibm/ibmveth.c | 107 ++++++++++++++++++++++++++++++-------
>  drivers/net/ethernet/ibm/ibmveth.h |   1 +
>  2 files changed, 90 insertions(+), 18 deletions(-)
>