ACK/cmnt: [Artful][PATCH 00/12] Backport for Power9 Nest PMU Instrumentation

Stefan Bader stefan.bader at canonical.com
Mon Nov 13 10:46:23 UTC 2017


On 02.11.2017 15:04, Gustavo Walbon wrote:
> BugLink: https://bugs.launchpad.net/bugs/1481347
> 
> This patchset enable the Power9 Nest PMU Counter to enable it for perf tool. 
> 
> These Nest PMU Counters provide per-chip metrics such memory bandwidth, Powerbus
> bandwidth and so on.
> 
> For test it needs Power9 machine with latest version of BMC and the minimum
> skiboot version v5.9-rc5.
> 
> Anju T (1):
>   powerpc/perf/imc: Fix nest events on muti socket system
> 
> Anju T Sudhakar (6):
>   powerpc/perf: Add nest IMC PMU support
>   powerpc/perf: Add core IMC PMU support
>   powerpc/perf: Add thread IMC PMU support
>   powerpc/perf: Fix for core/nest imc call trace on cpuhotplug
>   powerpc/perf: Add ___GFP_NOWARN flag to alloc_pages_node()
>   powerpc/perf: Fix IMC initialization crash
> 
> Dan Carpenter (1):
>   powerpc/perf: Fix double unlock in imc_common_cpuhp_mem_free()
> 
> LABBE Corentin (1):
>   powerpc/powernv: Fix build error in opal-imc.c when NUMA=n
> 
> Madhavan Srinivasan (3):
>   powerpc/powernv: Add IMC OPAL APIs
>   powerpc/powernv: Detect and create IMC device
>   powerpc/perf: Fix usage of nest_imc_refc
> 
>  arch/powerpc/include/asm/imc-pmu.h             |  128 +++
>  arch/powerpc/include/asm/opal-api.h            |   12 +-
>  arch/powerpc/include/asm/opal.h                |    5 +
>  arch/powerpc/perf/Makefile                     |    1 +
>  arch/powerpc/perf/imc-pmu.c                    | 1335 ++++++++++++++++++++++++
>  arch/powerpc/platforms/powernv/Makefile        |    1 +
>  arch/powerpc/platforms/powernv/opal-imc.c      |  226 ++++
>  arch/powerpc/platforms/powernv/opal-wrappers.S |    3 +
>  arch/powerpc/platforms/powernv/opal.c          |   14 +
>  include/linux/cpuhotplug.h                     |    3 +
>  10 files changed, 1727 insertions(+), 1 deletion(-)
>  create mode 100644 arch/powerpc/include/asm/imc-pmu.h
>  create mode 100644 arch/powerpc/perf/imc-pmu.c
>  create mode 100644 arch/powerpc/platforms/powernv/opal-imc.c
> 
As Artful is released now, the bug report needs SRU justification info added.
Also, is this part of upstream 4.14 or would Bionic still need to pick up the set?

Generally looks isolated and testable, so

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20171113/a36229e6/attachment.sig>


More information about the kernel-team mailing list