[SRU] [Xenial] [PATCH 0/1] Fix keyboard led sysfs cannot control its brightness

Kai-Heng Feng kai.heng.feng at canonical.com
Wed May 31 04:43:35 UTC 2017

On Tue, May 30, 2017 at 8:33 PM, Stefan Bader
<stefan.bader at canonical.com> wrote:
> On 25.05.2017 05:29, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1693126
>> Impact:
>> On some new dell laptops, the keyboard led backlight sysfs cannot control its brightness:
>>  dell_laptop: Setting old previous keyboard state failed
>>  leds dell::kbd_backlight: Setting an LED's brightness failed (-6)
>> Fix:
>> Commit 9216e0dcb5533a999d544d0af8661118e0588e1d can fix the issue:
>>  This patch adds support for retrieving current timeout AC values and also
>>  updating them. Current timeout value in sysfs is displayed based on current
>>  AC status, like current display brightness value.
>> The patch uses dell_smbios_find_token() which is a refactored version of
>> find_token_location(). I use the latter one to avoid unnecessary patch series.
>> Test:
>> Keyboad backlight now can be correctly controlled by sysfs
>> "dell:kbd_backlight/brightness" on Dell Precision 3520.
>> Pali Rohár (1):
>>   platform/x86: dell-laptop: Add keyboard backlight timeout AC settings
>>  drivers/platform/x86/dell-laptop.c | 59 ++++++++++++++++++++++++++++++++++----
>>  1 file changed, 53 insertions(+), 6 deletions(-)
> This change is relate to "Support new chassis type for dell-laptop", so it would
> be better to group both patches together. It is also a bit weird that this one
> is only asked for Xenial and the other one for Yakkety and Zesty, too.

dell-laptop on Yakkey and Zesty had some function name changing and
refactoring, but not on Xenial. So unfortunately the Xenial one needs
some extra care.

> -Stefan
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

More information about the kernel-team mailing list