[SRU] [Y/Z] [PATCH 0/1] Fix keyboard led sysfs cannot control its brightness

[Kai-Heng Feng]

On Tue, May 30, 2017 at 4:39 PM, Colin Ian King
<colin.king at canonical.com> wrote:
> On 25/05/17 04:29, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1693126
>>
>> Impact:
>> On some new dell laptops, the keyboard led backlight sysfs cannot control its brightness:
>>  dell_laptop: Setting old previous keyboard state failed
>>  leds dell::kbd_backlight: Setting an LED's brightness failed (-6)
>>
>> Fix:
>> Commit 9216e0dcb5533a999d544d0af8661118e0588e1d can fix the issue:
>>  This patch adds support for retrieving current timeout AC values and also
>>  updating them. Current timeout value in sysfs is displayed based on current
>>  AC status, like current display brightness value.
>>
>> Test:
>> Keyboad backlight now can be correctly controlled by sysfs
>> "dell:kbd_backlight/brightness" on Dell Precision 3520.
>>
>> Pali Rohár (1):
>>   platform/x86: dell-laptop: Add keyboard backlight timeout AC settings
>>
>>  drivers/platform/x86/dell-laptop.c | 59 ++++++++++++++++++++++++++++++++++----
>>  1 file changed, 53 insertions(+), 6 deletions(-)
>>
>
> I'd like the all SRU specific details (impact/fix/test and also very
> importantly the regression risk added to the bug report to make SRU
> review a little easier.

Thanks for the notice, I updated it with more information.

>
> This fix is from upstream, is targeted to a limited set of devices and
> has positive test results.
>
> Acked-by: Colin Ian King <colin.king at canonical.com>