ACK/wcmt: [SRU][Yakkety][PATCH 1/1] scsi: ses: Fix SAS device detection in enclosure

[Colin Ian King]

On 26/05/17 17:28, Joseph Salisbury wrote:
> From: "Ewan D. Milne" <emilne at redhat.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/1691899
> 
> The call to scsi_is_sas_rphy() needs to be made on the SAS end_device,
> not on the SCSI device.
> 
> Fixes: 835831c57e9b ("ses: use scsi_is_sas_rphy instead of is_sas_attached")
> Signed-off-by: Ewan D. Milne <emilne at redhat.com>
> Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
> Reviewed-by: James Bottomley <James.Bottomley at HansenPartnership.com>
> Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
> (cherry picked from commit 9373eba6cfae48911b977d14323032cd5d161aae)
> Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
> ---
>  drivers/scsi/ses.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
> index 8c9a35c..50adabb 100644
> --- a/drivers/scsi/ses.c
> +++ b/drivers/scsi/ses.c
> @@ -587,7 +587,7 @@ static void ses_match_to_enclosure(struct enclosure_device *edev,
>  
>  	ses_enclosure_data_process(edev, to_scsi_device(edev->edev.parent), 0);
>  
> -	if (scsi_is_sas_rphy(&sdev->sdev_gendev))
> +	if (scsi_is_sas_rphy(sdev->sdev_target->dev.parent))
>  		efd.addr = sas_get_address(sdev);
>  
>  	if (efd.addr) {
> 

Clean upstream cherry pick that has been tested to show it fixes the issue.

The SRU information does not describe any regression potential, can that
be fixed up when it gets put into the bug report?

Apart from that,

Acked-by: Colin Ian King <colin.king at canonical.com>