ACK/cmnt: [PATCH 0/2] [SRU] [X/master] NLS_ISO8859_1=y

Stefan Bader stefan.bader at canonical.com
Wed Mar 29 14:42:44 UTC 2017


On 29.03.2017 16:17, Stefan Bader wrote:
> On 29.03.2017 15:53, Paolo Pisati wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1677230
>>
>> The vfat kernel code has two dependencies: the code page (437) and the iocharset
>> (iso8859-1), and while the former is built-in (like the vfat code itself), the
>> latter is built as an external module, making vfat unusable unless the
>> nsl_iso8859-1 ko is available at the moment a vfat filesystem is mounted.
>>
>> What is just a discrepancy in the config that we never hit (since we are
>> shipping the nsl_iso8859-1 .ko in our initrd), became a problem in kernel
>> derivatives of our -generic kernel (e.g. snappy) where we don't have any control
>> on the modules people pack in their initrd, and in case the boot partition is a
>> vfat partition that is being mounted during the boot.
>>
>> For this reason, i propose to fix the root problem and turn
>> CONFIG_NLS_ISO8859_1=y to make the vfat code completely independent on any
>> external factor.
>>
>> Paolo Pisati (2):
>>   UBUNTU: [Config] NLS_ISO8859_1=y
>>   UBUNTU: fix module list after NLS_ISO8859_1=y
> 
> Hm I have a feeling that there also needs to be an update to the enforcer for
> this...

So it seems not *need* but maybe should be changed and enforced then...
Though that could be a follow-up or only in zesty. So ACK for this but also
would squash both changes into one.

-Stefan
> 
> 
>>
>>  debian.master/abi/4.4.0-64.85/amd64/generic.modules          | 1 -
>>  debian.master/abi/4.4.0-64.85/amd64/lowlatency.modules       | 1 -
>>  debian.master/abi/4.4.0-64.85/arm64/generic.modules          | 1 -
>>  debian.master/abi/4.4.0-64.85/armhf/generic-lpae.modules     | 1 -
>>  debian.master/abi/4.4.0-64.85/armhf/generic.modules          | 1 -
>>  debian.master/abi/4.4.0-64.85/i386/generic.modules           | 1 -
>>  debian.master/abi/4.4.0-64.85/i386/lowlatency.modules        | 1 -
>>  debian.master/abi/4.4.0-64.85/powerpc/powerpc-e500mc.modules | 1 -
>>  debian.master/abi/4.4.0-64.85/powerpc/powerpc-smp.modules    | 1 -
>>  debian.master/abi/4.4.0-64.85/powerpc/powerpc64-emb.modules  | 1 -
>>  debian.master/abi/4.4.0-64.85/powerpc/powerpc64-smp.modules  | 1 -
>>  debian.master/abi/4.4.0-64.85/ppc64el/generic.modules        | 1 -
>>  debian.master/abi/4.4.0-64.85/s390x/generic.modules          | 1 -
>>  debian.master/config/config.common.ubuntu                    | 2 +-
>>  14 files changed, 1 insertion(+), 14 deletions(-)
>>
> 
> 
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170329/35af7e3e/attachment.sig>


More information about the kernel-team mailing list