[kteam-tools 4/5] [link-to-tracker] Cleanups: additional fixes to please pylint

[Juerg Haefliger]

Non-functional changes to fix the following pylint issues:
  - Old-style class defined. (old-style-class)
  - Redefining name 'args' from outer scope (redefined-outer-name)
  - Comparison to False should be 'not expr' or 'expr is False' (singleton-comparison)
  - Unreachable code (unreachable)
  - Using possibly undefined loop variable 'bugid' (undefined-loop-variable)
  - Unused cinfo imported from ktl.log (unused-import)

Signed-off-by: Juerg Haefliger <juerg.haefliger at canonical.com>
---
 stable/link-to-tracker | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/stable/link-to-tracker b/stable/link-to-tracker
index d784268e0dfa..63f6b3fe9b8f 100755
--- a/stable/link-to-tracker
+++ b/stable/link-to-tracker
@@ -4,7 +4,7 @@
 from datetime                           import datetime, timedelta
 from argparse                           import ArgumentParser, RawDescriptionHelpFormatter
 from logging                            import basicConfig, DEBUG, INFO, WARNING
-from ktl.log                            import center, cleave, cdebug, cinfo, Clog
+from ktl.log                            import center, cleave, cdebug, Clog
 from ktl.launchpad                      import Launchpad
 from ktl3.git                           import Git
 from ktl3.debian                        import Debian
@@ -71,7 +71,7 @@ class WorkflowBugTask(object):
 
 # Tracking
 #
-class Tracking():
+class Tracking(object):
     '''
     '''
     # __init__
@@ -151,6 +151,7 @@ class Tracking():
         retval = 1
         try:
             target_package, target_series = self.repo_info
+            bugid = 0
             found = False
             for bugid in self.trackers(self.project_tracked):
                 tasks_by_name = self.create_tasks_by_name_mapping(bugid, self.project_tracked)
@@ -158,9 +159,9 @@ class Tracking():
                     found = True
                     break
 
-            if found == False:
+            if not found:
                 raise AppError('Cannot find tracker bug matching package %s series %s' % (target_package, target_series))
-                exit(retval)
+
             # -------------------------------------------------------------------------------------
             # C H A N G E L O G   W O R K
 
@@ -212,23 +213,23 @@ if __name__ == '__main__':
     parser = ArgumentParser(description=app_description, epilog=app_epilog, formatter_class=RawDescriptionHelpFormatter)
     parser.add_argument('--info', action='store_true', default=False, help='')
     parser.add_argument('--debug', action='store_true', default=False, help='')
-    args = parser.parse_args()
+    pargs = parser.parse_args()
 
     # If logging parameters were set on the command line, handle them
     # here.
     #
     Clog.color = True
-    if args.debug:
+    if pargs.debug:
         log_format = "%(levelname)s - %(message)s"
         basicConfig(level=DEBUG, format=log_format)
         Clog.dbg = True
-    elif args.info:
+    elif pargs.info:
         log_format = "%(message)s"
         basicConfig(level=INFO, format=log_format)
     else:
         log_format = "%(message)s"
         basicConfig(level=WARNING, format=log_format)
 
-    exit(Tracking(args).main())
+    exit(Tracking(pargs).main())
 
 # vi:set ts=4 sw=4 expandtab syntax=python:
-- 
2.11.0