[PATCH][SRU][Xenial] UBUNTU: SAUCE: Fix can't disable USB port issue

Brad Figg brad.figg at canonical.com
Mon Jun 26 17:13:14 UTC 2017


On Mon, Jun 26, 2017 at 11:02:31AM +0800, AceLan Kao wrote:
> BugLink: http://bugs.launchpad.net/bugs/1695216
> 
> [Impact]
> In BIOS, there is front USB port disable function.
> It is supposed the option in BIOS can disable USB port, but due to AMD chip's
> limitation, it needs OS’s cowork. Otherwise the USB disable function will
> be invalid when resuming from S3 or reinsert USB device.
> 
> [Fix]
> After checking with Windows, we found there are 2 bits that are default on
> in Ubuntu is disabled in Windows. They are 
> 	#define PORT_WKOC_E     (1<<22)         /* wake on overcurrent (enable) */
> 	#define PORT_WKCONN_E   (1<<20)         /* wake on connect (enable) */
> So, this patch introduce a quirk to not setup the wakeup bits only for
> AMD USB chips.
> 
> [Test Case]
> Verified on the machine has this issue, and confirm this patch works.
> 
> [Regression Potential]
> This patch only affects the listed USB ID, and we don't cert this kind of
> wakeup method, so should have no regression concerns.
> Wake up from USB device is still working, and the patch behavior is confirmed by
> the project lead, Tsai, Nicholas, from AMD in the discussion thread[1].
> 
> [Misc]
> This patch is accepted by the maintainer but still not shown up in any git tree
> yet. The discussion thread can be found here[1]. To fit the project schedule,
> we need this commit in our kernel as soon as possbile, and can't wait to
> next SRU release cycle.
> 
> 1. https://www.spinics.net/lists/linux-usb/msg157789.html
> 
> Jiahau Chang (1):
>   xhci: AMD Promontory USB disable port support
> 
>  drivers/usb/host/xhci-hub.c |  2 ++
>  drivers/usb/host/xhci-pci.c | 13 +++++++++++++
>  drivers/usb/host/xhci.h     |  2 ++
>  3 files changed, 17 insertions(+)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

The above information should be added to the Bug Description of the LP bug.

Brad
-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com



More information about the kernel-team mailing list