zesty SRU, LP#1668726

Colin Ian King colin.king at canonical.com
Fri Jun 23 10:21:15 UTC 2017


CoverityScan picked up a regression with the patches for LP#1668726

    CID 1435473 (#1 of 1): Uninitialized scalar variable (UNINIT)59.
uninit_use_in_call: Using uninitialized value reply. Field
reply.sense_data_size is uninitialized when calling copy_to_user.

 967                if (copy_to_user(user_reply, &reply,
 968                        sizeof(struct aac_srb_reply))) {
 969                        dprintk((KERN_DEBUG"aacraid: Copy to user
failed\n"));
 970                        rcode = -EFAULT;
 971                        goto cleanup;


git blame -L 966,966 drivers/scsi/aacraid/commctrl.c
5a05cc7cf1120 (Raghava Aditya Renukunta 2017-02-02 15:53:29 -0800 966)
       if (copy_to_user(user_reply, &reply,


commit 5a05cc7cf11200db420d213c05ee96305bfcc286
Author: Raghava Aditya Renukunta <RaghavaAditya.Renukunta at microsemi.com>
Date:   Thu Feb 2 15:53:29 2017 -0800

    scsi: aacraid: Include HBA direct interface

    BugLink: http://bugs.launchpad.net/bugs/1668726


Cheers,

Colin




More information about the kernel-team mailing list