ACK/cmnt: [SRU][Trusty][PATCH 0/5] Fixes for LP:1690094

[Stefan Bader]

On 02.06.2017 17:19, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1690094
> 
> == SRU Justification ==
> 
> Netlink notification is missing when an interface is modified on kernels 
> older that 3.18.  These commits are only needed in Trusty.  An example of 
> this bug is:
> 
> ip monitor link&
> ip link set eth1 txqueuelen 18
> 
> => no notification
> 
> This bugs is fixed by four commits, which also require on commit as a prereq, 
> which is commit 7d49b1f0f8e5.
> 
> These commits were included in maline as follows:
> 7d49b1f0f8e5f24294a880ed576964059af5ef - v3.14-rc1~94^2~25
> 5d1180fcacc5ceb7da5494acfe9c5e4ebad4f2 - v3.18-rc1~52^2~173^2~3
> 1889b0e7efe8373793069bd3deb7702a51e6f2 - v3.18-rc1~52^2~173^2~2
> 90c325e3bfe14ef360de6650fa2a2e92685e5c - v3.18-rc1~52^2~173^2~1
> ba9989069f4e426b1e0ed7018eacc9e1ba6070 - v3.18-rc1~52^2~173^2

Moving forward I would like to have the SRU justification in the bug report and
be geared to assess the risk which a change will cause.
Additional info in the email cover letter should be helping the reviewer to
understand modifications. Like how much had a backport to change.

Series seems to mostly add a new interface and appears to be tested. Joe, if you
could add some SRU justification into the description part of the bug report.

Thanks,
Stefan

Acked-by: Stefan Bader <stefan.bader at canonical.com>

> 
> == Fixes ==
> commit ba7d49b1f0f8e5f24294a880ed576964059af5ef
> Author: Jiri Pirko <jiri at resnulli.us>
> Date:   Wed Jan 22 09:05:55 2014 +0100
> 
>     rtnetlink: provide api for getting and setting slave info
> 
> commit 5d1180fcacc5ceb7da5494acfe9c5e4ebad4f281
> Author: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
> Date:   Mon Sep 1 16:07:26 2014 +0200
> 
>     rtnl/do_setlink(): set modified when IFLA_TXQLEN is updated
> 
> commit 1889b0e7efe8373793069bd3deb7702a51e6f2a5
> Author: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
> Date:   Mon Sep 1 16:07:27 2014 +0200
> 
>     rtnl/do_setlink(): set modified when IFLA_LINKMODE is updated
> 
> commit 90c325e3bfe14ef360de6650fa2a2e92685e5cee
> Author: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
> Date:   Mon Sep 1 16:07:28 2014 +0200
> 
>     rtnl/do_setlink(): last arg is now a set of flags
> 
> commit ba9989069f4e426b1e0ed7018eacc9e1ba607095
> Author: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
> Date:   Mon Sep 1 16:07:29 2014 +0200
> 
>     rtnl/do_setlink(): notify when a netdev is modified
> 
> == Regression Potential ==
> There is a chance for regression due to the number of changes.  However, two of
> the patches are to print warning messages.
> 
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> Jiri Pirko (1):
>   rtnetlink: provide api for getting and setting slave info
> 
> Nicolas Dichtel (4):
>   rtnl/do_setlink(): set modified when IFLA_TXQLEN is updated
>   rtnl/do_setlink(): set modified when IFLA_LINKMODE is updated
>   rtnl/do_setlink(): last arg is now a set of flags
>   rtnl/do_setlink(): notify when a netdev is modified
> 
>  include/net/rtnetlink.h      |  14 +++
>  include/uapi/linux/if_link.h |   2 +
>  net/core/rtnetlink.c         | 219 +++++++++++++++++++++++++++++++++++--------
>  3 files changed, 195 insertions(+), 40 deletions(-)
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170621/4ea4cd74/attachment.sig>