Fwd: New Defects reported by Coverity Scan for ubuntu-yakkety-kernel

[Colin Ian King]

Picked up on today's static analysis on Yakkety.

-------- Forwarded Message --------
Subject: New Defects reported by Coverity Scan for ubuntu-yakkety-kernel
Date: Fri, 09 Jun 2017 02:37:28 -0700
From: scan-admin at coverity.com
To: colin.king at canonical.com


Hi,

Please find the latest report on new defect(s) introduced to
ubuntu-yakkety-kernel found with Coverity Scan.

1 new defect(s) introduced to ubuntu-yakkety-kernel found with Coverity
Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1419695:    (RESOURCE_LEAK)
/fs/crypto/keyinfo.c: 246 in fscrypt_get_encryption_info()
/fs/crypto/keyinfo.c: 246 in fscrypt_get_encryption_info()


________________________________________________________________________________________________________
*** CID 1419695:    (RESOURCE_LEAK)
/fs/crypto/keyinfo.c: 246 in fscrypt_get_encryption_info()
240     	crypto_skcipher_set_flags(ctfm, CRYPTO_TFM_REQ_WEAK_KEY);
241     	res = crypto_skcipher_setkey(ctfm, raw_key,
fscrypt_key_size(mode));
242     	if (res)
243     		goto out;
244     245     	if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) ==
NULL)
>>>     CID 1419695:    (RESOURCE_LEAK)
>>>     Overwriting "crypt_info" in "crypt_info = NULL" leaks the storage that "crypt_info" points to.
246     		crypt_info = NULL;
247     248     out:
249     	if (res == -ENOKEY)
250     		res = 0;
251     	put_crypt_info(crypt_info);
/fs/crypto/keyinfo.c: 246 in fscrypt_get_encryption_info()
240     	crypto_skcipher_set_flags(ctfm, CRYPTO_TFM_REQ_WEAK_KEY);
241     	res = crypto_skcipher_setkey(ctfm, raw_key,
fscrypt_key_size(mode));
242     	if (res)
243     		goto out;
244     245     	if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) ==
NULL)
>>>     CID 1419695:    (RESOURCE_LEAK)
>>>     Overwriting "crypt_info" in "crypt_info = NULL" leaks the storage that "crypt_info" points to.
246     		crypt_info = NULL;
247     248     out:
249     	if (res == -ENOKEY)
250     		res = 0;
251     	put_crypt_info(crypt_info);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZd8m-2BCYS83Gpc6CPaqTQF1bJMwOn9jMy3ALwpQ6CGNIiBJA8TxCf2QESwot41Sh-2Fg-3D_OFgvmg1J6naJevMotmPmRlTuZxP1uJqXcOMG9f4qAi6h3aUa7pkaSlUdIYuA-2B72aSF1LLTsQ6cMfjYPWAAMABAVpPk54p96ReafspUXi5RC-2BN0b7dC6YBQjHWl-2BRnn-2BbZ9ZvUG6zcOLj0ky4Gw1oktNdayHGHbpVbZ-2Bucz5XInP286OgyIxA71ymDAnLvS-2F9brparLmMJBRo5zNNT9CSk2zSydFI1qvULsnf7EnhSLo-3D

To manage Coverity Scan email notifications for
"colin.king at canonical.com", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4B9nVBKVtwXiB4-2BdsKOQxbDQl0BcI5D9DhMHlVfgmixOEEI4TtjS4yCHzIkIbOF3ak-2BkflVDj0B1S6cLQhIOPZuGvnvI2bEt6aTZvzYSvWdc-3D_OFgvmg1J6naJevMotmPmRlTuZxP1uJqXcOMG9f4qAi6h3aUa7pkaSlUdIYuA-2B72aSF1LLTsQ6cMfjYPWAAMABNaqsEuh608DJlN8obyGPFAdqDiy-2FHrzmQVbUbsdHLMZSB99zzVSbBBE7AoXCvr-2F5aP-2FyOtg-2FymEtK9sOEa55QSXuoJdqRGa2Hqh0il36vX9K5McTthhlUPZytfXxnltGl6Qowu-2FbcwIo8NRH-2FeD4CU-3D