ACK/cmnt: [SRU Y/Z] [PATCH 1/1] nvme: Quirk APST on Intel 600P/P3100 devices

[Stefan Bader]

On 02.06.2017 06:55, Kai-Heng Feng wrote:
> From: Andy Lutomirski <luto at kernel.org>
> 
> BugLink: https://bugs.launchpad.net/bugs/1686592
> 
> They have known firmware bugs.  A fix is apparently in the works --
> once fixed firmware is available, someone from Intel (Hi, Keith!)
> can adjust the quirk accordingly.
> 
> Cc: stable at vger.kernel.org # v4.11
> Cc: Kai-Heng Feng <kai.heng.feng at canonical.com>
> Cc: Mario Limonciello <mario_limonciello at dell.com>
> Signed-off-by: Andy Lutomirski <luto at kernel.org>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> (backported from commit 50af47d04ca530544b27affffb0722f158e2bb9c)
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> ---
>  drivers/nvme/host/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 394038608734..2e61d3047435 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2288,6 +2288,8 @@ static const struct pci_device_id nvme_id_table[] = {
>  	{ PCI_VDEVICE(INTEL, 0x0a54),
>  		.driver_data = NVME_QUIRK_STRIPE_SIZE |
>  				NVME_QUIRK_DISCARD_ZEROES, },
> +	{ PCI_VDEVICE(INTEL, 0xf1a5),	/* Intel 600P/P3100 */
> +		.driver_data = NVME_QUIRK_NO_DEEPEST_PS },
>  	{ PCI_VDEVICE(INTEL, 0x5845),	/* Qemu emulated controller */
>  		.driver_data = NVME_QUIRK_IDENTIFY_CNS, },
>  	{ PCI_DEVICE(0x1c58, 0x0003),	/* HGST adapter */
> 

Indeed better to quirk right now. Just wondering, the future work likely needs
to apply quirks not only by vendor/model but firmware, too. Right?

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170602/a6fd5a8a/attachment.sig>