ACK/cmt / APPLIED [artful/unstable]: [SRU Z/A] [PATCH 0/2] Fix interrupt storm caused by pinctrl-amd on Gigabyte boards

Seth Forshee seth.forshee at canonical.com
Thu Jun 1 20:37:02 UTC 2017


On Thu, Jun 01, 2017 at 01:12:15PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1671360
> 
> [Impact]
> pinctrl-amd on Gigabyte AM4 boards generate interrupt storms, makes the system
> unable to boot.
> 
> [Fix]
> Commit "pinctrl: amd: make use of raw_spinlock variants" is to make another
> commit a clean cherrypick.
> Commit "pinctrl/amd: Use regular interrupt instead of chained" from
> linux-gpio/fixes can fix the issue. It changes the chained interrupt to regular
> interrupt.
> 
> [Test Case]
> User reported it does fix the issue in comment #170.
> 
> Julia Cartwright (1):
>   pinctrl: amd: make use of raw_spinlock variants
> 
> Thomas Gleixner (1):
>   pinctrl/amd: Use regular interrupt instead of chained
> 
>  drivers/pinctrl/pinctrl-amd.c | 160 ++++++++++++++++++++----------------------
>  drivers/pinctrl/pinctrl-amd.h |   2 +-
>  2 files changed, 76 insertions(+), 86 deletions(-)

Positive testing, limited scope. One nit though, with this:

(cherry picked from linux-pinctrl/fixes commit babdc22b0ccf4ef5a3075ce6e4afc26b7a279faf)

Please add the source of the fix after the sha1. Also this fix is in
linux-next, so better would be:

(cherry picked from commit babdc22b0ccf4ef5a3075ce6e4afc26b7a279faf linux-next)

I applied these to artful/master-next and unstable/master with the above
change. Assuming it's also changed when applied to zesty:

Acked-by: Seth Forshee <seth.forshee at canonical.com>





More information about the kernel-team mailing list