ACK: [PATCH] deb to snap building script: various improvements

[Kleber Souza]

On 07/26/17 17:49, Paolo Pisati wrote:
> This series of patches apply to our 'deb to snap' packaging scripts located
> here:
> 
> git://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux-snap/+git/xenial
> 
> Every patch applies to a different branch in that tree (see the subject), and
> specifically they go to:
> 
> "deb to snap build script: Enforce kernel version, and several
> other changes"			-> master branch
> "UBUNTU-Ubuntu-4.4.0.87.93"	-> pc branch
> "UBUNTU: Ubuntu-4.4.0.1065.66"	-> raspi2 branch
> "UBUNTU: Ubuntu-4.4.0.1067.60"	-> snapdragon branch
> "UBUNTU: Ubuntu-4.4.0.1026.29"	-> aws branch
> "UBUNTU: Ubuntu-4.4.0.1022.24"	-> gke branch
> 
> The main reason for this pull is to fix the kernel version used to build the
> snap, by passing the exact requested version from the consumer snapcraft's yaml
> to master/Makefile.
> 
> Among the changes in this pull, we have:
> 
> -split the PACKAGE argument in KERNEL and PKGS, and made KERNEL a mandatory
>  parameter
> -introduced a linux-pc-kernel meta pkg for i386 and amd64 pc-kernel variants,
>  internally it will be rewritten as linux-signed-image-generic or
>  linux-image-generic depending on the target arch
> -made the child branches (pc, raspi2, snapdragon, aws and gke) ask for a specific kernel
>  version via master/Makefile - that stops us from repackaging the latest kernel
>  version available in the archive, no matter the version we really wanted
> -stop using the -proposed pocket for the arm kernels
> -adjust the kernel version to follow the linux-image packages
> 
> There are two fallouts of this change:
> 
> 1) from now, snapcraft.yaml version field will follow the linux package version:
> 
> $ rmadison -s xenial-updates linux-snapdragon
>  linux-snapdragon | 4.4.0-1067.72 | xenial-updates/universe | source
>  linux-snapdragon | 4.4.0.1067.60 | xenial-updates/universe | arm64
> 
> the secondo onei (4.4.0.1067.60), instead of the first one (4.4.0-1067.72)
> 
> 2) the kernel snap will reflect the change:
> 
> $ snap list
> ...
> dragonboard-kernel  4.4.0.1067.60              x1               kernel
> 
> Tested by rebuilding all the kernel snaps several times (see the -test snap
> packages equivalent in lp), and by rebuilding an -edge pc/raspi2/snapdragon
> image, booting it out and competing the initialization.
> 
> For the record, i'm copying the body of this message to the patch that applies to
> master/Makefile.
> 
> Paolo Pisati (1):
>   Enforce kernel version, and several other changes
> 
>  Makefile | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>