ACK: [PATCH 1/2][Xenial SRU] UBUNTU: SAUCE: Redpine: enable power save by default for coex mode

Kleber Souza kleber.souza at canonical.com
Mon Jul 31 09:30:09 UTC 2017


On 07/28/17 13:22, Amitkumar Karwar wrote:
> From: Prameela Rani Garnepudi <prameela.j04cs at gmail.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1706991
> 
> When Coex mode is enabled, enabling power save will improve
> radio sharing. Hence PS on by default flag is set.
> 
> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs at gmail.com>
> Signed-off-by: Amitkumar Karwar <amit.karwar at redpinesignals.com>

Good test results and limited to the vendor driver.

On the next submissions, please include a cover letter email with some
technical background of the changes, as mentioned by Stefan on the first
submission of this series. This is useful mainly when sending multiple
patches, since ACK'ing or NACK'ing the cover letter states that this is
valid for all the patches in the series.


Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>


> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 003f49d..8a4100a 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -2835,6 +2835,9 @@ int rsi_mac80211_attach(struct rsi_common *common)
>  //			    NL80211_FEATURE_P2P_GO_OPPPS);
>  #endif
>  
> +	if (common->coex_mode > 1)
> +		wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT;
> +
>  	status = ieee80211_register_hw(hw);
>  	if (status) {
>  		ven_rsi_dbg(ERR_ZONE, "Failed to register to mac80211\n");
> 




More information about the kernel-team mailing list