[PATCH 1/2] UBUNTU: Redpine: enable power save by default for coex mode

[Shrirang Bagul]

On Thu, 2017-07-27 at 17:54 +0200, Stefan Bader wrote:
> On 27.07.2017 17:22, Amitkumar Karwar wrote:
> > From: Prameela Rani Garnepudi <prameela.j04cs at gmail.com>
> > 
> > BugLink: https://bugs.launchpad.net/bugs/1706991
> > 
> > When Coex mode is enabled, enabling power save will improve
> > radio sharing. Hence PS on by default flag is set.
> > 
> > Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs at gmail.com>
> > Signed-off-by: Amitkumar Karwar <amit.karwar at redpinesignals.com>
> > ---
> 
> Which release should those patches go into (guessing Xenial but nothing does say
> this)?
> Since this is not part of upstream Linux it would be "UBUNTU: SAUCE".
> The bug report should contain some SRU (stable release update) justification
> 
> --- TEMPLATE ---
> == SRU Justification ==
> 
> Impact:
> 
> Fix:
> 
> Testing:
> --- END --
> 
> which is supposed to help (non-kernel-team) members of the sru team to get a
> feeling about the risk associated with some fixes.
> 
> For sending to the mailing list it would be good to use a cover email
> 
> Subject: [Xenial SRU] <summary>
> 
> with some more technical background (summarized) about the patches.
> 
> -Stefan
For the Redpine driver in Xenial - ubuntu/rsi, please try and follow this subject
line template:

Subject: [Xenial SRU][PATCH] UBUNTU: SAUCE: Redpine: <summary>
(for reference: https://lists.ubuntu.com/archives/kernel-team/2017-June/084584.html)

Also helps to have the SRU justification on the launchpad bug, in case some one goes
looking for it.
Please  re-send the patch-set with suggested changes. I'll NAK this version for now.

-Shrirang
> >  ubuntu/rsi/rsi_91x_mac80211.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> > index 003f49d..8a4100a 100644
> > --- a/ubuntu/rsi/rsi_91x_mac80211.c
> > +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> > @@ -2835,6 +2835,9 @@ int rsi_mac80211_attach(struct rsi_common *common)
> >  //			    NL80211_FEATURE_P2P_GO_OPPPS);
> >  #endif
> >  
> > +	if (common->coex_mode > 1)
> > +		wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT;
> > +
> >  	status = ieee80211_register_hw(hw);
> >  	if (status) {
> >  		ven_rsi_dbg(ERR_ZONE, "Failed to register to mac80211\n");
> > 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170728/ab0274cd/attachment.sig>