ACK/cmnt: [PATCH 0/2] [SRU] [X/snapdragon] snapcraft.yaml: correct image format

[Stefan Bader]

On 27.07.2017 12:25, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/1706938
> 
> Impact:
> 
> The snapcraft.yaml that we are shipping in Xenial has two errors:
> 
> 1) it defaults to the snapcraft's arm64 kernel target (Image.gz) while the
> correct one should be Image
> 
> 2) it doesn't copy the dtbs from the SOC specific location to the dtbs root
> 
> The first one was my mistake while merging the new snapcraft.yaml from -generic
> with the one in the -snapdragon branch, the second is a consequence of the
> gadget snap dropping the dtb (and as such ubuntu-image looking for it in the
> kernel snap).
> 
> Fix:
> 
> Apply the attached patches to snapcraft.yaml and generate a new kernel snap
> 
> How to test it:
> 
> Generate a new snapdragon image[1] and boot it up.
> 
> 1: https://tutorials.ubuntu.com/tutorial/create-your-own-core-image#0
> 
> Paolo Pisati (2):
>   UBUNTU: snapcraft.yaml: force image format to Image
>   UBUNTU: snapcraft.yaml: install the apq8016-sbc and msm8916-mtp dtb
>     files
> 
>  snapcraft.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

Personally I am a friend of having explanations like this in the commits
themselves. So one has a clue by just reading git log.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170727/89668b3c/attachment.sig>