ACK: Cmnt: [zesty/linux xenial/linux trusty/linux 1/1] UBUNTU: [Packaging] tests -- reduce rebuild test to one flavour

[Marcelo Henrique Cerri]

On Thu, Jul 27, 2017 at 01:49:10PM +0100, Andy Whitcroft wrote:
> On Thu, Jul 27, 2017 at 08:59:36AM -0300, Marcelo Henrique Cerri wrote:
> > On Fri, Jul 21, 2017 at 05:17:20PM +0100, Andy Whitcroft wrote:
> > > BugLink: http://bugs.launchpad.net/bugs/1705495
> > > Signed-off-by: Andy Whitcroft <apw at canonical.com>
> > > ---
> > >  debian/rules         | 2 +-
> > >  debian/tests/rebuild | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/debian/rules b/debian/rules
> > > index 5fbe78f3265e..7f95f0c12ad7 100755
> > > --- a/debian/rules
> > > +++ b/debian/rules
> > > @@ -80,7 +80,7 @@ do_any_tools=$(sort $(filter-out false,$(do_linux_tools) $(do_cloud_tools)))
> > >  
> > >  # autopkgtest -- rebuild support
> > >  #  only build the first flavour on the assumption it is representative
> > > -ifeq ($(DEB_BUILD_PROFILE),autopkgtest)
> > > +ifeq ($(DEB_BUILD_PROFILES),autopkgtest)
> > 
> > Shouldn't this test be like that?
> > 
> > 	ifneq ($(filter autopkgtest,$(DEB_BUILD_PROFILES)),)
> 
> Strictly that is more correct yet.  As it happens our use case we will
> only ever want to use this profile on its own so the profile should be
> singular in all cases we care about this specific value.
> 
> -apw

Ok.

Acked-by: Marcelo Henrique Cerri <marcelo.cerri at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170727/fef20490/attachment.sig>