Cmnt: [zesty/linux xenial/linux trusty/linux 1/1] UBUNTU: [Packaging] tests -- reduce rebuild test to one flavour

[Marcelo Henrique Cerri]

On Fri, Jul 21, 2017 at 05:17:20PM +0100, Andy Whitcroft wrote:
> BugLink: http://bugs.launchpad.net/bugs/1705495
> Signed-off-by: Andy Whitcroft <apw at canonical.com>
> ---
>  debian/rules         | 2 +-
>  debian/tests/rebuild | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian/rules b/debian/rules
> index 5fbe78f3265e..7f95f0c12ad7 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -80,7 +80,7 @@ do_any_tools=$(sort $(filter-out false,$(do_linux_tools) $(do_cloud_tools)))
>  
>  # autopkgtest -- rebuild support
>  #  only build the first flavour on the assumption it is representative
> -ifeq ($(DEB_BUILD_PROFILE),autopkgtest)
> +ifeq ($(DEB_BUILD_PROFILES),autopkgtest)

Shouldn't this test be like that?

	ifneq ($(filter autopkgtest,$(DEB_BUILD_PROFILES)),)

Since `man dpkg-buildpackage` describes it as:

	The default behavior is to build for no specific profile. Also
	sets them (as a space separated list) as the DEB_BUILD_PROFILES
	environment variable which allows[...]

>  flavours := $(firstword $(flavours))
>  endif
>  
> diff --git a/debian/tests/rebuild b/debian/tests/rebuild
> index 6f73b36c1b5e..81491565a451 100644
> --- a/debian/tests/rebuild
> +++ b/debian/tests/rebuild
> @@ -17,4 +17,4 @@ if [ "$build_needed" -eq 0 ]; then
>  fi
>  
>  set -e
> -dpkg-buildpackage -rfakeroot -us -uc -b
> +dpkg-buildpackage -rfakeroot -us -uc -b -Pautopkgtest
> -- 
> 2.11.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170727/2c903c7a/attachment.sig>