ACK: [PATCH 0/5][SRU][Xenial] Fix failed to load intel bluetooth firmware
Aaron Ma
aaron.ma at canonical.com
Thu Jul 27 07:54:56 UTC 2017
On 07/25/2017 01:57 PM, AceLan Kao wrote:
> BugLink: http://bugs.launchpad.net/bugs/1705633
>
> [Impact]
> After this linux-firmware bug[1] update the firmware files, it removes intel/ibt-11-16.{ddc,sfi} and add intel/ibt-12-16.{ddc,sfi}, but in btusb driver, it hardcoded the hw_variant as 11. So we got this kind of error after the linux-firmware package updated and lost the bt functions.
>
> [ 5.516003] Bluetooth: hci0: Minimum firmware build 1 week 10 2014
> [ 5.516181] bluetooth hci0: Direct firmware load for intel/ibt-11-16.sfi failed with error -2
> [ 5.516183] Bluetooth: hci0: Failed to load Intel firmware file (-2)
>
> [Fix]
> This patch uses a hw_variant variable to replace the hardcoded 11.
>
> [Test Case]
> Verified on the machine has this issue, and confirm this patch works.
>
> [Regression Potential]
> The hw_variant variable has shown up since kernel 3.10 in this commit
> dffd30e Bluetooth: Add support for Intel Bluetooth device [8087:07dc]
> So, we don't have to worry about old chips don't contains this info, since it exists
> and be used for a very long time.
>
> 1. https://bugs.launchpad.net/ubuntu/+source/linux-firmware/+bug/1686815
>
> Jürg Billeter (1):
> Bluetooth: btintel: Add MODULE_FIRMWARE entries for iBT 3.5
> controllers
>
> Loic Poulain (1):
> Bluetooth: btintel: Create common Intel Version Read function
>
> Tedd Ho-Jeong An (3):
> Bluetooth: Use switch statement for Intel hardware variants
> Bluetooth: Replace constant hw_variant from Intel Bluetooth firmware
> filename
> Bluetooth: hci_intel: Fix firmware file name to use hw_variant
>
> drivers/bluetooth/btintel.c | 27 +++++++++++
> drivers/bluetooth/btintel.h | 7 +++
> drivers/bluetooth/btusb.c | 103 ++++++++++++++++--------------------------
> drivers/bluetooth/hci_intel.c | 77 +++++++++++++------------------
> 4 files changed, 104 insertions(+), 110 deletions(-)
>
Backport looks correct.
Acked-by: Aaron Ma <aaron.ma at canonical.com>
More information about the kernel-team
mailing list