ACK/APPLIED: [PATCH] [Zesty] powerpc/powernv: Fix boot on Power8 bare metal due to opal_configure_cores()
Kleber Souza
kleber.souza at canonical.com
Tue Jul 18 07:42:59 UTC 2017
On 07/18/17 09:11, Stefan Bader wrote:
> On 18.07.2017 03:05, Michael Ellerman wrote:
>> Breno Leitao <leitao at debian.org> writes:
>>
>>> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
>>> index e0f856bfbfe8..a3b6de84f49c 100644
>>> --- a/arch/powerpc/platforms/powernv/opal.c
>>> +++ b/arch/powerpc/platforms/powernv/opal.c
>>> @@ -66,11 +68,24 @@ void opal_configure_cores(void)
>>> * but it might clobber a bunch.
>>> */
>>> #ifdef __BIG_ENDIAN__
>>> - opal_reinit_cpus(OPAL_REINIT_CPUS_HILE_BE);
>>> + reinit_flags |= OPAL_REINIT_CPUS_HILE_BE;
>>> #else
>>> - opal_reinit_cpus(OPAL_REINIT_CPUS_HILE_LE);
>>> + reinit_flags |= OPAL_REINIT_CPUS_HILE_LE;
>>> #endif
>>>
>>> + /*
>>> + * POWER9 always support running hash:
>>> + * ie. Host hash supports hash guests
>>> + * Host radix supports hash/radix guests
>>> + */
>>> + if (cpu_has_feature(CPU_FTR_ARCH_300)) {
>>
>> This is wrong. It can break booting on bare-metal Power8 machines with
>> some versions of firmware.
>>
>> Fix here:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=fixes&id=a70b487b07cf4201bc6702e7f646fa593b23009f
>>
>> http://patchwork.ozlabs.org/patch/789381/
>
> Ok, that is in linux-next by now (see attached).
>
> -Stefan
Attached patch (powerpc/powernv: Fix boot on Power8 bare metal due to
opal_configure_cores()) acked and applied to zesty/master-next branch.
Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
More information about the kernel-team
mailing list