NAK: [SRU][Zesty][PATCH 1/1] powerpc/npu-dma: Remove spurious WARN_ON when a PCI device has no of_node

Joseph Salisbury joseph.salisbury at canonical.com
Wed Jul 12 15:27:50 UTC 2017


On 07/12/2017 10:55 AM, Seth Forshee wrote:
> On Wed, Jul 12, 2017 at 09:47:54AM -0400, Joseph Salisbury wrote:
>> From: Alistair Popple <alistair at popple.id.au>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1702768
>>
>> Commit 4c3b89effc28 ("powerpc/powernv: Add sanity checks to
>> pnv_pci_get_{gpu|npu}_dev") introduced explicit warnings in
>> pnv_pci_get_npu_dev() when a PCIe device has no associated device-tree
>> node. However not all PCIe devices have an of_node and
>> pnv_pci_get_npu_dev() gets indirectly called at least once for every
>> PCIe device in the system. This results in spurious WARN_ON()'s so
>> remove it.
>>
>> The same situation should not exist for pnv_pci_get_gpu_dev() as any
>> NPU based PCIe device requires a device-tree node.
>>
>> Fixes: 4c3b89effc28 ("powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev")
>> Reported-by: Alexey Kardashevskiy <aik at ozlabs.ru>
>> Signed-off-by: Alistair Popple <alistair at popple.id.au>
>> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
>> (cherry picked from commit 377aa6b0efbaa29cfeecd8b9244641217f9544ca)
>> Signed-off-by: Joseph Salisbury <joseph.salisbury at canonical.com>
> This patch was already sent/applied for another bug report:
>
> https://lists.ubuntu.com/archives/kernel-team/2017-June/085279.html
>
> So this bug probably should just be duped to the one there.

Thanks, Seth.  I'll dupe it.





More information about the kernel-team mailing list