ACK/cmnt: [X/Y/Z][v2] ath10k: search SMBIOS for OEM board file extension

Stefan Bader stefan.bader at canonical.com
Wed Jul 12 08:27:14 UTC 2017


On 06.07.2017 13:12, Shrirang Bagul wrote:
> BugLink: https://bugs.launchpad.net/bugs/1666742
> 
> Patches for ath10k driver to read board variant from SMBIOS.
> 
> Patch for Zesty is a clean cherry-pick. Yakkety and Xenial are backports
> only due to difference in context.
> 
> Example:
>  If a default board data file for a specific board is identified by a string
>          "bus=pci,vendor=168c,device=003e,subsystem-vendor=1028,
>          	subsystem-device=0310"
>  then the OEM specific data file, if used, could be identified by variant
>  suffix:
>          "bus=pci,vendor=168c,device=003e,subsystem-vendor=1028,
>          	subsystem-device=0310,variant=DE_1AB"
> 
> If board data file name extension is set but board-2.bin does not contain board
> data file for the variant, the driver will fallback to the default board data
> file not to break backward compatibility.
> 
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

Looks to be isolated to very specific HW and defaulting to unchanged behaviour.
Though would induce more confidence if the bug report would mention testing on
some HW with special variant (and if available one without).

-Stefan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170712/9a188a81/attachment.sig>


More information about the kernel-team mailing list