[kteam-tools v2 3/3] [verify-release-ready] Also check display name 'linux' for derivative fixes

Kleber Souza kleber.souza at canonical.com
Thu Jul 6 16:25:14 UTC 2017



On 07/05/17 08:02, Juerg Haefliger wrote:
> 
>>>          for bug in changelog_bugs:
>>> @@ -377,13 +384,19 @@ class VerifyReleaseReady():
>>>              is_fix_committed = False
>>>              for task in lp_bug.bug_tasks:
>>>                  task_display_name = task.bug_target_display_name.lower()
>>> -                # if the display name 'linux (ubuntu X)' matches our package continue
>>> -                if changelog_source_package in task_display_name:
>>> +
>>> +                # if the display name 'linux (ubuntu X)' matches our package
>>> +                # or the package is a derivative and the diplay name is 'linux'
>>> +                # (which means the fix is in the master tree), continue...
>>> +                if ((task_display_name.startswith(changelog_source_package + ' ') or
>>> +                     (derivative and task_display_name.startswith('linux ')))):
>>>                      is_targeted_to_package = True
>>
>> These names are "normally" the right format for this, but you might
>> consider using the task.self_link which is more predicatable in form.
> 
> I'd rather not introduce a new but attribute but extend the current logic.
> 

The attribute is already available on the 'task' object, and getting the
exact name of the package affected by the bug could be done by something
like:

re.search('\+source/(.+?)/', task.self_link).group(1)


> ...Juerg
> 
> 
>>> +
>>>                      # if the display name contains the series, or we are devel continue
>>>                      if (changelog_series in task_display_name) or \
>>>                         (changelog_series == s.lp_devel_series.displayname.lower()):
>>>                          is_targeted_to_series = True
>>> +
>>>                          # if we are on a devel or series targeted task check status of that task
>>>                          if task.status in (u'Fix Committed', u'Fix Released'):
>>>                              is_fix_committed = True
>>> -- 
>>> 2.11.0
>>>
>>>
>>> -- 
>>> kernel-team mailing list
>>> kernel-team at lists.ubuntu.com
>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> 
> 
> 




More information about the kernel-team mailing list