ACK: [Xenial] powerpc/powernv: Call opal_pci_poll() if needed

[Luis Henriques]

On Tue, Jan 03, 2017 at 08:54:55PM -0200, Thadeu Lima de Souza Cascardo wrote:
> From: Gavin Shan <gwshan at linux.vnet.ibm.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1652018
> 
> When issuing PHB reset, OPAL API opal_pci_poll() is called to drive
> the state machine in OPAL forward. However, we needn't always call
> the function under some circumstances like reset deassert.
> 
> This avoids calling opal_pci_poll() when OPAL_SUCCESS is returned
> from opal_pci_reset(). Except the overhead introduced by additional
> one unnecessary OPAL call, I didn't run into real issue because of
> this.
> 
> Reported-by: Pridhiviraj Paidipeddi <ppaiddipe at in.ibm.com>
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
> (backported from commit fbce44d0ed42e4653172376f4dfeaa5710f06a27)
> [cascardo: use original pnv_eeh_phb_poll]
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
> ---
>  arch/powerpc/platforms/powernv/eeh-powernv.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c
> index 9273685..94d1e49 100644
> --- a/arch/powerpc/platforms/powernv/eeh-powernv.c
> +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c
> @@ -777,7 +777,8 @@ int pnv_eeh_phb_reset(struct pci_controller *hose, int option)
>  	 * reset followed by hot reset on root bus. So we also
>  	 * need the PCI bus settlement delay.
>  	 */
> -	rc = pnv_eeh_phb_poll(phb);
> +	if (rc > 0)
> +		rc = pnv_eeh_phb_poll(phb);
>  	if (option == EEH_RESET_DEACTIVATE) {
>  		if (system_state < SYSTEM_RUNNING)
>  			udelay(1000 * EEH_PE_RST_SETTLE_TIME);
> @@ -820,7 +821,8 @@ static int pnv_eeh_root_reset(struct pci_controller *hose, int option)
>  		goto out;
>  
>  	/* Poll state of the PHB until the request is done */
> -	rc = pnv_eeh_phb_poll(phb);
> +	if (rc > 0)
> +		rc = pnv_eeh_phb_poll(phb);
>  	if (option == EEH_RESET_DEACTIVATE)
>  		msleep(EEH_PE_RST_SETTLE_TIME);
>  out:
> -- 
> 2.9.3
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Cheers,
--
Luís
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20170106/00aed495/attachment.sig>